diff --git a/.pick_status.json b/.pick_status.json index f1aac076e34..5b08cbb62b6 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -5914,7 +5914,7 @@ "description": "ac/nir/ngg: fix gs culling vertex liveness check for odd vertices", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "1bdeb961bd8c953713646ae0ea28cc5f21f4a232", "notes": null diff --git a/src/amd/common/ac_nir_lower_ngg.c b/src/amd/common/ac_nir_lower_ngg.c index 29c64505856..d7f6bbd0db8 100644 --- a/src/amd/common/ac_nir_lower_ngg.c +++ b/src/amd/common/ac_nir_lower_ngg.c @@ -2733,6 +2733,7 @@ lower_ngg_gs_emit_vertex_with_counter(nir_builder *b, nir_intrinsic_instr *intri /* Calculate and store per-vertex primitive flags based on vertex counts: * - bit 0: whether this vertex finishes a primitive (a real primitive, not the strip) * - bit 1: whether the primitive index is odd (if we are emitting triangle strips, otherwise always 0) + * only set when the vertex also finishes the primitive * - bit 2: whether vertex is live (if culling is enabled: set after culling, otherwise always 1) */ @@ -2746,8 +2747,9 @@ lower_ngg_gs_emit_vertex_with_counter(nir_builder *b, nir_intrinsic_instr *intri nir_ssa_def *prim_flag = nir_ior(b, vertex_live_flag, complete_flag); if (s->num_vertices_per_primitive == 3) { - nir_ssa_def *odd = nir_iand_imm(b, current_vtx_per_prim, 1); - prim_flag = nir_iadd_nuw(b, prim_flag, nir_ishl(b, odd, nir_imm_int(b, 1))); + nir_ssa_def *odd = nir_iand(b, current_vtx_per_prim, complete_flag); + nir_ssa_def *odd_flag = nir_ishl(b, odd, nir_imm_int(b, 1)); + prim_flag = nir_ior(b, prim_flag, odd_flag); } nir_store_shared(b, nir_u2u8(b, prim_flag), gs_emit_vtx_addr, .base = s->lds_offs_primflags + stream, .align_mul = 4u);