From 5aba130eabc4248ff94bcadade95e2d2b25f240a Mon Sep 17 00:00:00 2001 From: Samuel Pitoiset Date: Tue, 26 Aug 2025 11:43:33 +0200 Subject: [PATCH] radv: check if SQTT is enabled before calling radv_describe_draw() This is faster. Signed-off-by: Samuel Pitoiset Part-of: --- src/amd/vulkan/layers/radv_sqtt_layer.c | 3 +-- src/amd/vulkan/radv_cmd_buffer.c | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/layers/radv_sqtt_layer.c b/src/amd/vulkan/layers/radv_sqtt_layer.c index 0f22684d327..78643467cca 100644 --- a/src/amd/vulkan/layers/radv_sqtt_layer.c +++ b/src/amd/vulkan/layers/radv_sqtt_layer.c @@ -344,8 +344,7 @@ radv_describe_draw(struct radv_cmd_buffer *cmd_buffer, const struct radv_draw_in const struct radv_device *device = radv_cmd_buffer_device(cmd_buffer); const struct radv_physical_device *pdev = radv_device_physical(device); - if (likely(!device->sqtt.bo)) - return; + assert(device->sqtt.bo); radv_write_event_marker(cmd_buffer, cmd_buffer->state.current_event_type, UINT_MAX, UINT_MAX, UINT_MAX); diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 62965eb91f8..03ad11a3469 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/src/amd/vulkan/radv_cmd_buffer.c @@ -11836,7 +11836,7 @@ radv_before_draw(struct radv_cmd_buffer *cmd_buffer, const struct radv_draw_info radv_gfx12_emit_buffered_regs(device, cs); } - if (!dgc) + if (device->sqtt.bo && !dgc) radv_describe_draw(cmd_buffer, info); if (likely(!info->indirect_va)) { struct radv_cmd_state *state = &cmd_buffer->state; @@ -11917,7 +11917,7 @@ radv_before_taskmesh_draw(struct radv_cmd_buffer *cmd_buffer, const struct radv_ radv_gfx12_emit_buffered_regs(device, cmd_buffer->gang.cs); } - if (!dgc) + if (device->sqtt.bo && !dgc) radv_describe_draw(cmd_buffer, info); if (likely(!info->indirect_va)) { struct radv_cmd_state *state = &cmd_buffer->state;