From 5979e74177eb3013ca7e78867295e9a015e6c8ed Mon Sep 17 00:00:00 2001 From: Faith Ekstrand Date: Thu, 26 Oct 2023 08:01:15 -0500 Subject: [PATCH] nir/lower_bit_size: Fix subgroup lowering for floats MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Using u2u is always correct for integers, including signed integers, because we're doing a down-cast. It's wrong for floats, though. Fixes: f95665cfebbd ("nir/lower_bit_size: Add support for lowering subgroup ops") Reviewed-by: Daniel Schürmann Reviewed-by: Timur Kristóf Part-of: --- src/compiler/nir/nir_lower_bit_size.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_lower_bit_size.c b/src/compiler/nir/nir_lower_bit_size.c index 37889a39faf..35097b85d83 100644 --- a/src/compiler/nir/nir_lower_bit_size.c +++ b/src/compiler/nir/nir_lower_bit_size.c @@ -203,7 +203,7 @@ lower_intrinsic_instr(nir_builder *b, nir_intrinsic_instr *intrin, if (intrin->intrinsic != nir_intrinsic_vote_feq && intrin->intrinsic != nir_intrinsic_vote_ieq) - res = nir_u2uN(b, res, old_bit_size); + res = nir_convert_to_bit_size(b, res, type, old_bit_size); nir_def_rewrite_uses(&intrin->def, res); break;