diff --git a/.pick_status.json b/.pick_status.json index 7d60aceec09..d706bd89b2e 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -2324,7 +2324,7 @@ "description": "panfrost: Process scissor state earlier", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "because_sha": "79356b2e5f1762aeaaa81cc148cd5b469a47713d" }, { diff --git a/src/gallium/drivers/panfrost/pan_cmdstream.c b/src/gallium/drivers/panfrost/pan_cmdstream.c index 8b36aae8b21..e55ff5c8f78 100644 --- a/src/gallium/drivers/panfrost/pan_cmdstream.c +++ b/src/gallium/drivers/panfrost/pan_cmdstream.c @@ -2628,9 +2628,6 @@ panfrost_update_state_3d(struct panfrost_batch *batch) { unsigned dirty = batch->ctx->dirty; - if (dirty & (PAN_DIRTY_VIEWPORT | PAN_DIRTY_SCISSOR)) - batch->viewport = panfrost_emit_viewport(batch); - if (dirty & PAN_DIRTY_TLS_SIZE) panfrost_batch_adjust_stack_size(batch); } @@ -3133,6 +3130,19 @@ panfrost_draw_vbo(struct pipe_context *pipe, /* Do some common setup */ struct panfrost_batch *batch = panfrost_get_batch_for_fbo(ctx); + /* Don't add too many jobs to a single batch. Hardware has a hard limit + * of 65536 jobs, but we choose a smaller soft limit (arbitrary) to + * avoid the risk of timeouts. This might not be a good idea. */ + if (unlikely(batch->scoreboard.job_index > 10000)) + batch = panfrost_get_fresh_batch_for_fbo(ctx, "Too many draws"); + + /* panfrost_batch_skip_rasterization reads + * batch->scissor_culls_everything, which is set by + * panfrost_emit_viewport, so call that first. + */ + if (ctx->dirty & (PAN_DIRTY_VIEWPORT | PAN_DIRTY_SCISSOR)) + batch->viewport = panfrost_emit_viewport(batch); + /* If rasterization discard is enabled but the vertex shader does not * have side effects (including transform feedback), skip the draw * altogether. This is always an optimization. Additionally, this is @@ -3149,12 +3159,6 @@ panfrost_draw_vbo(struct pipe_context *pipe, return; } - /* Don't add too many jobs to a single batch. Hardware has a hard limit - * of 65536 jobs, but we choose a smaller soft limit (arbitrary) to - * avoid the risk of timeouts. This might not be a good idea. */ - if (unlikely(batch->scoreboard.job_index > 10000)) - batch = panfrost_get_fresh_batch_for_fbo(ctx, "Too many draws"); - unsigned zs_draws = ctx->depth_stencil->draws; batch->draws |= zs_draws; batch->resolve |= zs_draws; diff --git a/src/panfrost/ci/panfrost-g52-fails.txt b/src/panfrost/ci/panfrost-g52-fails.txt index 60df76e709f..11113beaabb 100644 --- a/src/panfrost/ci/panfrost-g52-fails.txt +++ b/src/panfrost/ci/panfrost-g52-fails.txt @@ -593,7 +593,6 @@ spec@!opengl 2.1@pbo@test_polygon_stip,Fail spec@!opengl 2.1@polygon-stipple-fs,Fail spec@!opengl 3.0@gl-3.0-vertexattribipointer,Fail spec@!opengl 3.0@required-texture-attachment-formats,Fail -spec@!opengl 3.0@viewport-clamp,Crash spec@!opengl 3.1@primitive-restart-xfb flush,Fail spec@!opengl 3.1@primitive-restart-xfb generated,Fail spec@!opengl 3.1@primitive-restart-xfb written,Fail