fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-02 14:28:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

aco: Allow passing constant operand to is_overwritten_since.

Browse source 
This is to make it more intuitive and also consistent
with last_writer_idx which does allow constant operands.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28046>
This commit is contained in:
Timur Kristóf 2024-03-07 15:20:11 +01:00 • committed by Marge Bot
parent d1cac5ed05
commit 58e3b1f930
1 changed files with 13 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/amd/compiler/aco_optimizer_postRA.cpp
View file

@ -230,11 +230,19 @@ is_overwritten_since(pr_opt_ctx& ctx, PhysReg reg, RegClass rc, const Idx& since
return false;
}
template <typename T>
bool
is_overwritten_since(pr_opt_ctx& ctx, const T& t, const Idx& idx, bool inclusive = false)
is_overwritten_since(pr_opt_ctx& ctx, const Definition& def, const Idx& idx, bool inclusive = false)
{
return is_overwritten_since(ctx, t.physReg(), t.regClass(), idx, inclusive);
return is_overwritten_since(ctx, def.physReg(), def.regClass(), idx, inclusive);
}
bool
is_overwritten_since(pr_opt_ctx& ctx, const Operand& op, const Idx& idx, bool inclusive = false)
{
if (op.isConstant())
return false;
return is_overwritten_since(ctx, op.physReg(), op.regClass(), idx, inclusive);
}
void
@ -382,7 +390,7 @@ try_optimize_scc_nocompare(pr_opt_ctx& ctx, aco_ptr<Instruction>& instr)
/* Check whether the operands of the writer are overwritten. */
for (const Operand& op : wr_instr->operands) {
if (!op.isConstant() && is_overwritten_since(ctx, op, wr_idx))
if (is_overwritten_since(ctx, op, wr_idx))
return;
}
@ -523,7 +531,7 @@ try_eliminate_scc_copy(pr_opt_ctx& ctx, aco_ptr<Instruction>& instr)
/* Verify that the operands of the producer instruction haven't been overwritten. */
for (const Operand& op : producer_instr->operands) {
if (!op.isConstant() && is_overwritten_since(ctx, op, producer_idx, true))
if (is_overwritten_since(ctx, op, producer_idx, true))
return;
}