From 5839b9d0839efd7ea3d69a167bce8517e01ba6a2 Mon Sep 17 00:00:00 2001 From: Paulo Zanoni Date: Tue, 27 Aug 2024 16:35:42 -0700 Subject: [PATCH] anv/trtt: remove TODO comment regarding the reloc list We use 2MB page table BOs, as defined by ANV_TRTT_PAGE_TABLE_BO_SIZE. Each BO is enough to hold 512 pages, since each one has 4096 bytes. Each L1 page can fit 1024 entries of 64kb size, which means our 512 pages should be able to fit a little less than 32gb of sparse resource memory, since we also need some L2 pages and an L3 page. I don't see any real world application using more than a single BO. Reviewed-by: Lionel Landwerlin Signed-off-by: Paulo Zanoni Part-of: --- src/intel/vulkan/anv_sparse.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/intel/vulkan/anv_sparse.c b/src/intel/vulkan/anv_sparse.c index 037dd127b13..fa25be75e26 100644 --- a/src/intel/vulkan/anv_sparse.c +++ b/src/intel/vulkan/anv_sparse.c @@ -811,11 +811,7 @@ anv_sparse_bind_trtt(struct anv_device *device, goto out_add_bind; } - /* Add all the BOs backing TRTT page tables to the reloc list. - * - * TODO: we could narrow down the list by using anv_address structures in - * anv_trtt_bind for the pte_addr. - */ + /* Add all the BOs backing TRTT page tables to the reloc list. */ if (device->physical->uses_relocs) { for (int i = 0; i < trtt->num_page_table_bos; i++) { result = anv_reloc_list_add_bo(&submit->base.relocs,