From 5771727e70e449c8b048d52dd9c70efc4bdb0ceb Mon Sep 17 00:00:00 2001 From: Erik Faye-Lund Date: Tue, 26 Nov 2024 11:26:59 +0100 Subject: [PATCH] st/mesa: check requirements for MESA_texture_const_bandwidth MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This extension depends on EXT_memory_object, and is not usable without it. So let's disable it, so applications don't try to use it. Fixes: 5cccd6d689c ("mesa: Implement MESA_texture_const_bandwidth") Reviewed-by: Marek Olšák Reviewed-by: Rob Clark Part-of: (cherry picked from commit 7b0d4012656caff20d3fb7473f25e45fe9a24c8f) --- .pick_status.json | 2 +- src/mesa/state_tracker/st_extensions.c | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.pick_status.json b/.pick_status.json index b66e6286720..442ee7a102a 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -1384,7 +1384,7 @@ "description": "st/mesa: check requirements for MESA_texture_const_bandwidth", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "5cccd6d689c5104599beef5793865d68837488b5", "notes": null diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 06e26b73947..6a0d84c0358 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/state_tracker/st_extensions.c @@ -1161,6 +1161,10 @@ void st_init_extensions(struct pipe_screen *screen, } } + /* MESA_texture_const_bandwidth depends on EXT_memory_object */ + if (!extensions->EXT_memory_object) + extensions->MESA_texture_const_bandwidth = GL_FALSE; + /* EXT implies ARB here */ if (extensions->EXT_texture_filter_minmax) extensions->ARB_texture_filter_minmax = GL_TRUE;