fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-06 13:48:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

pvr: Explain why dynamic descriptors are allocated separately.

Browse source 
Signed-off-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20008>
This commit is contained in:
Karmjit Mahil 2022-11-09 17:02:19 +00:00
parent c5d91ab254
commit 567ae39738
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/imagination/vulkan/pvr_descriptor_set.c
View file

@ -585,9 +585,10 @@ VkResult pvr_CreateDescriptorSetLayout(
internal_binding->shader_stage_mask |= (1U << stage);
/* TODO: Do we have to allocate them at the end? We could speed it
* by allocating them here if not. */
/* We allocate dynamics primary and secondaries at the end. */
/* We allocate dynamics primary and secondaries separately so that we
* can do a partial update of USC shared registers by just DMAing the
* dynamic section and not having to re-DMA everything again.
*/
if (descriptor_type != VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC &&
descriptor_type != VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) {
struct pvr_descriptor_size_info size_info;