fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-07 11:28:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

panfrost: remove needless variable

Browse source 
We can already tell if we're writing the first variable by looking at
sig_offset. So let's drop the needless variable here.

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37903>
This commit is contained in:
Erik Faye-Lund 2025-10-15 09:58:50 +02:00 • committed by Marge Bot
parent 9839db709a
commit 55ef52d009
1 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/gallium/drivers/panfrost/pan_fb_preload.c
View file

@ -407,7 +407,6 @@ pan_preload_get_shader(struct pan_fb_preload_cache *cache,
unsigned sig_offset = 0;
char sig[256];
sig[0] = '\0';
bool first = true;
for (unsigned i = 0; i < ARRAY_SIZE(key->surfaces); i++) {
const char *type_str, *dim_str;
if (key->surfaces[i].type == nir_type_invalid)
@ -447,19 +446,16 @@ pan_preload_get_shader(struct pan_fb_preload_cache *cache,
coord_comps = MAX2(coord_comps, (key->surfaces[i].dim ?: 3) +
(key->surfaces[i].array ? 1 : 0));
if (sig_offset >= sizeof(sig)) {
first = false;
if (sig_offset >= sizeof(sig))
continue;
}
sig_offset +=
snprintf(sig + sig_offset, sizeof(sig) - sig_offset,
"%s[%s;%s;%s%s;samples=%d]",
first ? "" : ",", gl_frag_result_name(key->surfaces[i].loc),
sig_offset == 0 ? "" : ",",
gl_frag_result_name(key->surfaces[i].loc),
type_str, dim_str, key->surfaces[i].array ? "[]" : "",
key->surfaces[i].samples);
first = false;
}
nir_builder b = nir_builder_init_simple_shader(