fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 09:08:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

pan/bi: Fix constant slot selection

Browse source 
The fau_index field contains the lower 4 bits of the 64bit constant,
which allows one to reuse the same clause constant slot from different
bundles if the upper 60 bits match. That doesn't work for constants
referenced from the same instruction or for constants referenced from
two instructions that are part of the same bundle though, since the
fau_index is shared in that case.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8418>
This commit is contained in:
Boris Brezillon 2020-11-23 23:03:59 +01:00 • committed by Marge Bot
parent c80c68cd49
commit 556a5cb575
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/panfrost/bifrost/bi_pack.c
View file

@ -70,7 +70,13 @@ bi_lookup_constant(bi_clause *clause, uint32_t cons, bool *hi)
/* Try to apply to top or to bottom */
uint64_t top = clause->constants[i];
if (cons == ((uint32_t) top | (cons & 0xF)))
/* Constant slots can actually be used by a different
* tuples if the 60 upper bits match since the 4 LSB are
* encoded in the tuple itself. Let's not bother about this
* case until we start scheduling more than one tuple per
* clause.
*/
if (cons == (uint32_t) top)
return i;
if (cons == (top >> 32ul)) {