fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-02-21 01:20:30 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

nv50: properly flush the TSC cache on 3D

Browse source 
The change didn't make any sense. `s` will always be
`NV50_SHADER_STAGE_COMPUTE`, because it's used to loop over all shader
stages. And the TSC cache on the compute side is already flushed in
`nv50_compute_validate_samplers`.

Fixes spurious `CACHE_ERROR` dmesg messages.

Fixes: ba6ba8c990 ("nv50: adapt texture and constbuf paths for compute shaders")
Signed-off-by: Karol Herbst <kherbst@redhat.com>
Reviewed-by: M Henning <drawoc@darkrefraction.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18382>
This commit is contained in:
Karol Herbst 2022-09-02 00:10:05 +02:00 • committed by Marge Bot
parent b23b94fbc9
commit 54709efd5e
1 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/gallium/drivers/nouveau/nv50/nv50_tex.c
View file

@ -441,11 +441,7 @@ void nv50_validate_samplers(struct nv50_context *nv50)
need_flush |= nv50_validate_tsc(nv50, s);
if (need_flush) {
if (unlikely(s == NV50_SHADER_STAGE_COMPUTE))
// TODO(pmoreau): Is this needed? Not done on nvc0
BEGIN_NV04(nv50->base.pushbuf, NV50_CP(TSC_FLUSH), 1);
else
BEGIN_NV04(nv50->base.pushbuf, NV50_3D(TSC_FLUSH), 1);
BEGIN_NV04(nv50->base.pushbuf, NV50_3D(TSC_FLUSH), 1);
PUSH_DATA (nv50->base.pushbuf, 0);
}