From 53d5655bc175ca48c08e14fe5c3552b7ceddb10e Mon Sep 17 00:00:00 2001 From: Mary Guillemard Date: Mon, 21 Jul 2025 16:17:34 +0200 Subject: [PATCH] pan/genxml: Add missing parenthesis on pan_cast_and_pack macros We were missing parenthesis on pan_cast_and_pack macros causing various issues. Signed-off-by: Mary Guillemard Fixes: 410e5a36ec88 ("pan/genxml: Rework gen_pack.py to support OpenCL") Reviewed-by: Erik Faye-Lund Part-of: (cherry picked from commit 455b93601a19536bed7195b3fde8d7cf13a48e6a) --- .pick_status.json | 2 +- src/panfrost/lib/genxml/pan_pack_helpers.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index 272425f9364..732db4a63cd 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -4464,7 +4464,7 @@ "description": "pan/genxml: Add missing parenthesis on pan_cast_and_pack macros", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "410e5a36ec88b9e7702a7149554a1422debab535", "notes": null diff --git a/src/panfrost/lib/genxml/pan_pack_helpers.h b/src/panfrost/lib/genxml/pan_pack_helpers.h index 21e8b60260e..6781f33918a 100644 --- a/src/panfrost/lib/genxml/pan_pack_helpers.h +++ b/src/panfrost/lib/genxml/pan_pack_helpers.h @@ -121,10 +121,10 @@ __gen_padded(uint32_t v, uint32_t start, uint32_t end) * pointer address space */ #ifndef __OPENCL_VERSION__ #define pan_cast_and_pack(dst, T, name) \ - pan_pack((PREFIX2(T, PACKED_T) *)dst, T, name) + pan_pack((PREFIX2(T, PACKED_T) *)(dst), T, name) #define pan_cast_and_pack_nodefaults(dst, T, name) \ - pan_pack_nodefaults((PREFIX2(T, PACKED_T) *)dst, T, name) + pan_pack_nodefaults((PREFIX2(T, PACKED_T) *)(dst), T, name) #define pan_cast_and_unpack(src, T, name) \ pan_unpack((const PREFIX2(T, PACKED_T) *)(src), T, name)