fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 09:38:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

anv: track render targets & render area changes separately

Browse source 
The following instructions :
   - 3DSTATE_VIEWPORT_STATE_POINTERS_SF_CLIP
   - 3DSTATE_VIEWPORT_STATE_POINTERS_CC
   - 3DSTATE_SCISSOR_STATE_POINTERS

do not care about the content/format/count of the render targets, only
the size of the render area and count of viewport/scissor.

By tracking render targets & render area we can reduce the emission of
those instructions.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25778>
This commit is contained in:
Lionel Landwerlin 2023-10-18 10:54:01 +03:00
parent c0b6ce0aac
commit 53a4738eb1
3 changed files with 17 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/intel/vulkan/anv_private.h
View file

@ -2702,10 +2702,11 @@ anv_buffer_is_sparse(struct anv_buffer *buffer)
enum anv_cmd_dirty_bits {
ANV_CMD_DIRTY_PIPELINE = 1 << 0,
ANV_CMD_DIRTY_INDEX_BUFFER = 1 << 1,
ANV_CMD_DIRTY_RENDER_TARGETS = 1 << 2,
ANV_CMD_DIRTY_XFB_ENABLE = 1 << 3,
ANV_CMD_DIRTY_RESTART_INDEX = 1 << 4,
ANV_CMD_DIRTY_OCCLUSION_QUERY_ACTIVE = 1 << 5,
ANV_CMD_DIRTY_RENDER_AREA = 1 << 2,
ANV_CMD_DIRTY_RENDER_TARGETS = 1 << 3,
ANV_CMD_DIRTY_XFB_ENABLE = 1 << 4,
ANV_CMD_DIRTY_RESTART_INDEX = 1 << 5,
ANV_CMD_DIRTY_OCCLUSION_QUERY_ACTIVE = 1 << 6,
};
typedef enum anv_cmd_dirty_bits anv_cmd_dirty_mask_t;

12
src/intel/vulkan/genX_cmd_buffer.c
View file

@ -3510,7 +3510,8 @@ genX(BeginCommandBuffer)(
anv_cmd_graphic_state_update_has_uint_rt(gfx);
cmd_buffer->state.gfx.dirty |= ANV_CMD_DIRTY_RENDER_TARGETS;
cmd_buffer->state.gfx.dirty |= ANV_CMD_DIRTY_RENDER_AREA |
ANV_CMD_DIRTY_RENDER_TARGETS;
}
}
@ -7198,11 +7199,18 @@ void genX(CmdBeginRendering)(
trace_intel_begin_render_pass(&cmd_buffer->trace);
gfx->rendering_flags = pRenderingInfo->flags;
gfx->render_area = pRenderingInfo->renderArea;
gfx->view_mask = pRenderingInfo->viewMask;
gfx->layer_count = pRenderingInfo->layerCount;
gfx->samples = 0;
if (gfx->render_area.offset.x != pRenderingInfo->renderArea.offset.x ||
gfx->render_area.offset.y != pRenderingInfo->renderArea.offset.y ||
gfx->render_area.extent.width != pRenderingInfo->renderArea.extent.width ||
gfx->render_area.extent.height != pRenderingInfo->renderArea.extent.height) {
gfx->render_area = pRenderingInfo->renderArea;
gfx->dirty |= ANV_CMD_DIRTY_RENDER_AREA;
}
const bool is_multiview = gfx->view_mask != 0;
const VkRect2D render_area = gfx->render_area;
const uint32_t layers =

4
src/intel/vulkan/genX_gfx_state.c
View file

@ -907,7 +907,7 @@ genX(cmd_buffer_flush_gfx_runtime_state)(struct anv_cmd_buffer *cmd_buffer)
gfx->alpha_blend_zero ? 0.0f : dyn->cb.blend_constants[3]);
}
if ((gfx->dirty & ANV_CMD_DIRTY_RENDER_TARGETS) ||
if ((gfx->dirty & ANV_CMD_DIRTY_RENDER_AREA) ||
BITSET_TEST(dyn->dirty, MESA_VK_DYNAMIC_VP_VIEWPORTS) ||
BITSET_TEST(dyn->dirty, MESA_VK_DYNAMIC_VP_SCISSORS) ||
BITSET_TEST(dyn->dirty, MESA_VK_DYNAMIC_RS_DEPTH_CLAMP_ENABLE) ||
@ -1054,7 +1054,7 @@ genX(cmd_buffer_flush_gfx_runtime_state)(struct anv_cmd_buffer *cmd_buffer)
}
}
if ((gfx->dirty & ANV_CMD_DIRTY_RENDER_TARGETS) ||
if ((gfx->dirty & ANV_CMD_DIRTY_RENDER_AREA) ||
BITSET_TEST(dyn->dirty, MESA_VK_DYNAMIC_VP_SCISSORS) ||
BITSET_TEST(dyn->dirty, MESA_VK_DYNAMIC_VP_VIEWPORTS)) {
const VkRect2D *scissors = dyn->vp.scissors;