From 538fd7266e4e6fb7080c557c5fea7dd2e8cf79bb Mon Sep 17 00:00:00 2001 From: Caio Oliveira Date: Tue, 28 Oct 2025 16:06:10 -0700 Subject: [PATCH] brw: Fix EU validation of VxH and Vx1 region Use same approach as the other code checking for this vstride. Argument could be made we want to reuse the same enum value for both the encoded and decoded version, but for now follow the existing practice. This will cause dEQP-VK.spirv_assembly.instruction.compute.untyped_pointers.vulkan_memory_model.type_punning.load.push_constant.int64_to_uint64 and similar tests to fail validation on BMG. Later patch will fix that. Reviewed-by: Ian Romanick Part-of: --- src/intel/compiler/brw/brw_eu_validate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/compiler/brw/brw_eu_validate.c b/src/intel/compiler/brw/brw_eu_validate.c index 25e2df96518..3cc3cbebabb 100644 --- a/src/intel/compiler/brw/brw_eu_validate.c +++ b/src/intel/compiler/brw/brw_eu_validate.c @@ -1755,7 +1755,7 @@ special_requirements_for_handling_double_precision_data_types( if (devinfo->verx10 >= 125 && (brw_type_is_float_or_bfloat(type) || brw_type_size_bytes(type) == 8)) { ERROR_IF(address_mode == BRW_ADDRESS_REGISTER_INDIRECT_REGISTER && - vstride == BRW_VERTICAL_STRIDE_ONE_DIMENSIONAL, + vstride == STRIDE(BRW_VERTICAL_STRIDE_ONE_DIMENSIONAL), "Vx1 and VxH indirect addressing for Float, Half-Float, " "Double-Float, Quad-Word, and Bfloat16 data must not be used"); }