fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-02 07:20:16 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

glsl: Pass ast_type_qualifier by const reference.

Browse source 
Coverity noticed that we were passing this by value, and it's 152 bytes.

Reviewed-by: Timothy Arceri <timothy.arceri@collabora.com>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
This commit is contained in:
Matt Turner 2015-11-23 14:22:48 -08:00
parent f36993b469
commit 5369efe311
3 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/glsl/ast.h
View file

@ -699,16 +699,16 @@ struct ast_type_qualifier {
bool merge_qualifier(YYLTYPE *loc,
_mesa_glsl_parse_state *state,
ast_type_qualifier q);
const ast_type_qualifier &q);
bool merge_out_qualifier(YYLTYPE *loc,
_mesa_glsl_parse_state *state,
ast_type_qualifier q,
const ast_type_qualifier &q,
ast_node* &node);
bool merge_in_qualifier(YYLTYPE *loc,
_mesa_glsl_parse_state *state,
ast_type_qualifier q,
const ast_type_qualifier &q,
ast_node* &node);
ast_subroutine_list *subroutine_list;
@ -1152,7 +1152,7 @@ class ast_cs_input_layout : public ast_node
{
public:
ast_cs_input_layout(const struct YYLTYPE &locp,
ast_layout_expression **local_size)
ast_layout_expression *const *local_size)
{
for (int i = 0; i < 3; i++) {
this->local_size[i] = local_size[i];
@ -1197,6 +1197,6 @@ check_builtin_array_max_size(const char *name, unsigned size,
extern void _mesa_ast_process_interface_block(YYLTYPE *locp,
_mesa_glsl_parse_state *state,
ast_interface_block *const block,
const struct ast_type_qualifier q);
const struct ast_type_qualifier &q);
#endif /* AST_H */

6
src/glsl/ast_type.cpp
View file

@ -116,7 +116,7 @@ ast_type_qualifier::interpolation_string() const
bool
ast_type_qualifier::merge_qualifier(YYLTYPE *loc,
_mesa_glsl_parse_state *state,
ast_type_qualifier q)
const ast_type_qualifier &q)
{
ast_type_qualifier ubo_mat_mask;
ubo_mat_mask.flags.i = 0;
@ -293,7 +293,7 @@ ast_type_qualifier::merge_qualifier(YYLTYPE *loc,
bool
ast_type_qualifier::merge_out_qualifier(YYLTYPE *loc,
_mesa_glsl_parse_state *state,
ast_type_qualifier q,
const ast_type_qualifier &q,
ast_node* &node)
{
void *mem_ctx = state;
@ -309,7 +309,7 @@ ast_type_qualifier::merge_out_qualifier(YYLTYPE *loc,
bool
ast_type_qualifier::merge_in_qualifier(YYLTYPE *loc,
_mesa_glsl_parse_state *state,
ast_type_qualifier q,
const ast_type_qualifier &q,
ast_node* &node)
{
void *mem_ctx = state;

2
src/glsl/glsl_parser_extras.cpp
View file

@ -874,7 +874,7 @@ void
_mesa_ast_process_interface_block(YYLTYPE *locp,
_mesa_glsl_parse_state *state,
ast_interface_block *const block,
const struct ast_type_qualifier q)
const struct ast_type_qualifier &q)
{
if (q.flags.q.buffer) {
if (!state->has_shader_storage_buffer_objects()) {