fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-03-17 08:10:33 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

freedreno/a6xx: Fix snorm rounding

Browse source 
See util_format_r8g8b8a8_snorm_pack_rgba_float()

Fixes the remaining failures in images/clFillImage/test_cl_fill_images.

Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37319>
This commit is contained in:
Rob Clark 2025-09-11 14:32:56 -07:00 • committed by Marge Bot
parent 4f94ca6c96
commit 52e02c2b0b
1 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/gallium/drivers/freedreno/a6xx/fd6_blitter.cc
View file

@ -742,6 +742,12 @@ emit_blit_texture(struct fd_context *ctx, fd_cs &cs, const struct pipe_blit_info
}
}
static inline uint32_t
float_to_sbyte(float f)
{
return util_iround(CLAMP(f, -1.0f, 1.0f) * 0x7f) & 0xff;
}
/* nregs: 4 */
template <chip CHIP>
static void
@ -769,10 +775,10 @@ emit_clear_color(fd_ncrb<CHIP> &ncrb, enum pipe_format pfmt,
case R2D_UNORM8_SRGB:
/* The r2d ifmt is badly named, it also covers the signed case: */
if (util_format_is_snorm(pfmt)) {
ncrb.add(A6XX_RB_A2D_CLEAR_COLOR_DW0(float_to_byte_tex(color->f[0])));
ncrb.add(A6XX_RB_A2D_CLEAR_COLOR_DW1(float_to_byte_tex(color->f[1])));
ncrb.add(A6XX_RB_A2D_CLEAR_COLOR_DW2(float_to_byte_tex(color->f[2])));
ncrb.add(A6XX_RB_A2D_CLEAR_COLOR_DW3(float_to_byte_tex(color->f[3])));
ncrb.add(A6XX_RB_A2D_CLEAR_COLOR_DW0(float_to_sbyte(color->f[0])));
ncrb.add(A6XX_RB_A2D_CLEAR_COLOR_DW1(float_to_sbyte(color->f[1])));
ncrb.add(A6XX_RB_A2D_CLEAR_COLOR_DW2(float_to_sbyte(color->f[2])));
ncrb.add(A6XX_RB_A2D_CLEAR_COLOR_DW3(float_to_sbyte(color->f[3])));
} else {
ncrb.add(A6XX_RB_A2D_CLEAR_COLOR_DW0(float_to_ubyte(color->f[0])));
ncrb.add(A6XX_RB_A2D_CLEAR_COLOR_DW1(float_to_ubyte(color->f[1])));