fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 08:50:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

pan/decode: Express tiler structures as offsets

Browse source 
This allows us to catch a class of errors (for negative offsets, etc)
automatically.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
This commit is contained in:
Alyssa Rosenzweig 2019-08-19 10:38:25 -07:00
parent e918dd8a6c
commit 52101e48f8
1 changed files with 13 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
src/panfrost/pandecode/decode.c
View file

@ -486,19 +486,21 @@ pandecode_midgard_tiler_descriptor(const struct midgard_tiler_descriptor *t)
pandecode_prop("polygon_list_size = 0x%x", t->polygon_list_size);
MEMORY_PROP(t, polygon_list);
MEMORY_PROP(t, polygon_list_body);
/* The body is offset from the base of the polygon list */
assert(t->polygon_list_body > t->polygon_list);
unsigned body_offset = t->polygon_list_body - t->polygon_list;
/* It needs to fit inside the reported size */
assert(t->polygon_list_size >= body_offset);
/* TODO: Check BO size */
pandecode_msg("body offset %d\n", body_offset);
/* The tiler heap has a start and end specified. TODO: Check size */
MEMORY_PROP(t, heap_start);
if (t->heap_start == t->heap_end) {
/* Print identically to show symmetry for empty tiler heaps */
MEMORY_PROP(t, heap_end);
} else {
/* Points to the end of a buffer */
char *a = pointer_as_memory_reference(t->heap_end - 1);
pandecode_prop("heap_end = %s + 1", a);
free(a);
}
assert(t->heap_end >= t->heap_start);
pandecode_msg("heap size %d\n", t->heap_end - t->heap_start);
bool nonzero_weights = false;