From 51b9a929667c58c8cc92b23f0ac599e9246392ee Mon Sep 17 00:00:00 2001 From: Mohamed Ahmed Date: Wed, 11 Mar 2026 04:07:55 +0400 Subject: [PATCH] nil/modifiers: Clarify drm_format_mods_for_format rejecting modifiers for unsupported color formats Reviewed-by: Faith Ekstrand Reviewed-by: Mel Henning Tested-by: Mary Guillemard Backport-to: 26.1 Part-of: (cherry picked from commit 7f5767a2f2ccaeb9570d73f946455c7ef2d2f554) --- .pick_status.json | 2 +- src/nouveau/nil/modifiers.rs | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.pick_status.json b/.pick_status.json index 8042b325ae2..eb9867597b7 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -2214,7 +2214,7 @@ "description": "nil/modifiers: Clarify drm_format_mods_for_format rejecting modifiers for unsupported color formats", "nominated": true, "nomination_type": 4, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": null, "notes": null diff --git a/src/nouveau/nil/modifiers.rs b/src/nouveau/nil/modifiers.rs index 88556a7e3e8..ba177e39040 100644 --- a/src/nouveau/nil/modifiers.rs +++ b/src/nouveau/nil/modifiers.rs @@ -268,6 +268,7 @@ pub fn drm_format_mods_for_format( return; } + // This rejects unsupported color formats like YCbCr and any others if !format.supports_color_targets(dev) { return; }