fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 21:50:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

pvr: Disable PBE resolve on cores without gs_rta_support

Browse source 
On cores without gs_rta_support, PBE resolves might depend on writes
that occur within the deferred RTA clears that happen after the PBE
has written.
Since the driver can't know at renderpass creation whether RTA clears
are needed, PBE resolves must be disabled.

Fix for deqp-vk:
    dEQP-VK.api.image_clearing.*.clear_color_attachment.multiple_layers.*

Signed-off-by: Jarred Davies <jarred.davies@imgtec.com>
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36412>
This commit is contained in:
Jarred Davies 2024-12-09 13:56:15 +00:00 • committed by Marge Bot
parent d68344bffe
commit 508f044d41
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/imagination/vulkan/pvr_pass.c
View file

@ -564,6 +564,7 @@ VkResult pvr_CreateRenderPass2(VkDevice _device,
{
struct pvr_render_pass_attachment *attachments;
PVR_FROM_HANDLE(pvr_device, device, _device);
const struct pvr_device_info *dev_info = &device->pdevice->dev_info;
struct pvr_render_subpass *subpasses;
const VkAllocationCallbacks *alloc;
size_t subpass_attachment_count;
@ -636,10 +637,17 @@ VkResult pvr_CreateRenderPass2(VkDevice _device,
attachment->vk_format = desc->format;
attachment->sample_count = desc->samples;
attachment->initial_layout = desc->initialLayout;
attachment->index = i;
/* On cores without gs_rta_support, PBE resolves might depend on writes
* that occur within the deferred RTA clears that happen after the PBE has
* written. Since the driver doesn't know at renderpass creation whether
* RTA clears are needed, PBE resolves can't be used.
*/
attachment->is_pbe_downscalable =
PVR_HAS_FEATURE(dev_info, gs_rta_support) &&
pvr_format_is_pbe_downscalable(&device->pdevice->dev_info,
attachment->vk_format);
attachment->index = i;
if (attachment->sample_count > pass->max_sample_count)
pass->max_sample_count = attachment->sample_count;