fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-22 11:20:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

brw: Avoid invalid access when compacting out-of-bounds JIP/UIP
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
Details
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Details

Browse source 
Usually JIP will be valid, but as part of other changes, it will be
possible to have a shader that have multiple EOT messages and end with
and ENDIF instruction.  Its JIP will point after the program ends.
This is fine but was tripping up the compaction code.

Change compaction to not read its internal structures beyond the last
instruction.

Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36822>
This commit is contained in:
Caio Oliveira 2025-08-18 09:29:46 -07:00 • committed by Marge Bot
parent a5433b44e6
commit 4fda724fd4
1 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/intel/compiler/brw_eu_compact.c
View file

@ -2230,7 +2230,8 @@ compacted_between(int old_ip, int old_target_ip, int *compacted_counts)
static void static void
update_uip_jip(const struct brw_isa_info *isa, brw_eu_inst *insn, update_uip_jip(const struct brw_isa_info *isa, brw_eu_inst *insn,
int this_old_ip, int *compacted_counts) int this_old_ip, int *compacted_counts,
unsigned num_compacted_counts)
{ {
const struct intel_device_info *devinfo = isa->devinfo; const struct intel_device_info *devinfo = isa->devinfo;
@ -2244,8 +2245,10 @@ update_uip_jip(const struct brw_isa_info *isa, brw_eu_inst *insn,
brw_eu_inst_uip(devinfo, insn) % 8 == 0); brw_eu_inst_uip(devinfo, insn) % 8 == 0);
int32_t jip_compacted = brw_eu_inst_jip(devinfo, insn) >> shift; int32_t jip_compacted = brw_eu_inst_jip(devinfo, insn) >> shift;
jip_compacted -= compacted_between(this_old_ip, jip_compacted -= compacted_between(this_old_ip,
this_old_ip + (jip_compacted / 2), MIN2(this_old_ip + (jip_compacted / 2),
num_compacted_counts - 1),
compacted_counts); compacted_counts);
brw_eu_inst_set_jip(devinfo, insn, (uint32_t)jip_compacted << shift); brw_eu_inst_set_jip(devinfo, insn, (uint32_t)jip_compacted << shift);
@ -2255,8 +2258,10 @@ update_uip_jip(const struct brw_isa_info *isa, brw_eu_inst *insn,
return; return;
int32_t uip_compacted = brw_eu_inst_uip(devinfo, insn) >> shift; int32_t uip_compacted = brw_eu_inst_uip(devinfo, insn) >> shift;
uip_compacted -= compacted_between(this_old_ip, uip_compacted -= compacted_between(this_old_ip,
this_old_ip + (uip_compacted / 2), MIN2(this_old_ip + (uip_compacted / 2),
num_compacted_counts - 1),
compacted_counts); compacted_counts);
brw_eu_inst_set_uip(devinfo, insn, (uint32_t)uip_compacted << shift); brw_eu_inst_set_uip(devinfo, insn, (uint32_t)uip_compacted << shift);
} }
@ -2411,7 +2416,7 @@ brw_compact_instructions(struct brw_codegen *p, int start_offset,
case BRW_OPCODE_BREAK: case BRW_OPCODE_BREAK:
case BRW_OPCODE_CONTINUE: case BRW_OPCODE_CONTINUE:
case BRW_OPCODE_HALT: case BRW_OPCODE_HALT:
update_uip_jip(p->isa, insn, this_old_ip, compacted_counts); update_uip_jip(p->isa, insn, this_old_ip, compacted_counts, num_compacted_counts);
break; break;
case BRW_OPCODE_IF: case BRW_OPCODE_IF:
@ -2426,13 +2431,14 @@ brw_compact_instructions(struct brw_codegen *p, int start_offset,
(brw_eu_compact_inst *)insn); (brw_eu_compact_inst *)insn);
update_uip_jip(p->isa, &uncompacted, this_old_ip, update_uip_jip(p->isa, &uncompacted, this_old_ip,
compacted_counts); compacted_counts, num_compacted_counts);
bool ret = try_compact_instruction(&c, (brw_eu_compact_inst *)insn, bool ret = try_compact_instruction(&c, (brw_eu_compact_inst *)insn,
&uncompacted); &uncompacted);
assert(ret); (void)ret; assert(ret); (void)ret;
} else { } else {
update_uip_jip(p->isa, insn, this_old_ip, compacted_counts); update_uip_jip(p->isa, insn, this_old_ip, compacted_counts,
num_compacted_counts);
} }
break; break;