From 4fc2a6cbdb6fab868a2ee4ee753caa2e83cf6666 Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Mon, 9 Aug 2021 15:48:25 -0700 Subject: [PATCH] freedreno: Require C++17. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Commit 3a772be026c ("freedreno: Add perfetto renderpass support") uses C++17 init-statement feature. GCC ../src/gallium/drivers/freedreno/freedreno_perfetto.cc: In lambda function: ../src/gallium/drivers/freedreno/freedreno_perfetto.cc:148:11: warning: init-statement in selection statements only available with ‘-std=c++17’ or ‘-std=gnu++17’ 148 | if (auto state = tctx.GetIncrementalState(); state->was_cleared) { | ^~~~ Clang ../src/gallium/drivers/freedreno/freedreno_perfetto.cc:148:11: warning: 'if' initialization statements are a C++17 extension [-Wc++17-extensions] if (auto state = tctx.GetIncrementalState(); state->was_cleared) { ^ Intel C++ Compiler ../src/gallium/drivers/freedreno/freedreno_perfetto.cc(148): error: expected a ")" if (auto state = tctx.GetIncrementalState(); state->was_cleared) { ^ Fixes: 3a772be026c ("freedreno: Add perfetto renderpass support") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5193 Suggested-by: Erik Faye-Lund Signed-off-by: Vinson Lee Acked-by: Rob Clark Acked-by: Erik Faye-Lund Part-of: --- src/gallium/drivers/freedreno/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/freedreno/meson.build b/src/gallium/drivers/freedreno/meson.build index dac51b1c3c7..6cf833d335b 100644 --- a/src/gallium/drivers/freedreno/meson.build +++ b/src/gallium/drivers/freedreno/meson.build @@ -273,6 +273,7 @@ libfreedreno = static_library( cpp_args : [freedreno_cpp_args], gnu_symbol_visibility : 'hidden', dependencies : libfreedreno_dependencies, + override_options : ['cpp_std=c++17'], ) driver_freedreno = declare_dependency(