From 4f031f35fef27c0cbe83ed44e8eb6e882cccd918 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcin=20=C5=9Alusarz?= Date: Wed, 13 Apr 2022 13:09:23 +0200 Subject: [PATCH] anv: invalidate all metadata in anv_nir_lower_ubo_loads lower_ubo_load_instr may insert "if" blocks. Fixes: 61749b5a151 ("anv: Add a pass for lowering A64 UBO access") Reviewed-by: Lionel Landwerlin Reviewed-by: Jason Ekstrand Part-of: (cherry picked from commit 5bd3ba5b67f4a51bf21ea30b0a4f1c8d1551568e) --- .pick_status.json | 2 +- src/intel/vulkan/anv_nir_lower_ubo_loads.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index 6afc9f2898a..93b4c24846a 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -760,7 +760,7 @@ "description": "anv: invalidate all metadata in anv_nir_lower_ubo_loads", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "61749b5a1513888767c39b2099be3e82f8d91871" }, diff --git a/src/intel/vulkan/anv_nir_lower_ubo_loads.c b/src/intel/vulkan/anv_nir_lower_ubo_loads.c index 35b963835e6..5a170352c80 100644 --- a/src/intel/vulkan/anv_nir_lower_ubo_loads.c +++ b/src/intel/vulkan/anv_nir_lower_ubo_loads.c @@ -119,7 +119,6 @@ bool anv_nir_lower_ubo_loads(nir_shader *shader) { return nir_shader_instructions_pass(shader, lower_ubo_load_instr, - nir_metadata_block_index | - nir_metadata_dominance, + nir_metadata_none, NULL); }