From 4e6444af0befbae8c4aac4fe24c1cc3fe66eec4d Mon Sep 17 00:00:00 2001 From: Karmjit Mahil Date: Wed, 14 Jun 2023 15:47:23 +0100 Subject: [PATCH] pvr: Fix missing BITFIELD_BIT for winsys frag job flag On submission SPMSCRATCHBUFFER was acting like GET_VIS_RESULT + DEPTH_BUFFER_PRESENT. This was causing hardware resets on barrier stores as the depth buffer isn't actually present so the store would be carried out to a NULL address. Signed-off-by: Karmjit Mahil Reviewed-by: Frank Binns Part-of: --- src/imagination/vulkan/winsys/pvr_winsys.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/imagination/vulkan/winsys/pvr_winsys.h b/src/imagination/vulkan/winsys/pvr_winsys.h index 265f1633e72..f20a277bc24 100644 --- a/src/imagination/vulkan/winsys/pvr_winsys.h +++ b/src/imagination/vulkan/winsys/pvr_winsys.h @@ -325,7 +325,7 @@ struct pvr_winsys_compute_submit_info { #define PVR_WINSYS_FRAG_FLAG_PREVENT_CDM_OVERLAP BITFIELD_BIT(2U) #define PVR_WINSYS_FRAG_FLAG_SINGLE_CORE BITFIELD_BIT(3U) #define PVR_WINSYS_FRAG_FLAG_GET_VIS_RESULTS BITFIELD_BIT(4U) -#define PVR_WINSYS_FRAG_FLAG_SPMSCRATCHBUFFER (5U) +#define PVR_WINSYS_FRAG_FLAG_SPMSCRATCHBUFFER BITFIELD_BIT(5U) struct pvr_winsys_render_submit_info { struct pvr_winsys_rt_dataset *rt_dataset;