fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 09:08:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

tgsi/scan: correctly walk instructions in tgsi_scan_tess_ctrl()

Browse source 
The previous code used a do while loop and continues after walking
a nested loop/if-statement. This means we end up evaluating the
last instruction from the nested block against the while condition
and potentially exit early if it matches the exit condition of the
outer block.

Fixes: 386d165d8d ("tgsi/scan: add a new pass that analyzes tess factor writes")

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
This commit is contained in:
Timothy Arceri 2018-12-14 15:36:02 +11:00
parent dd061eb044
commit 4dda445750
1 changed files with 43 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

72
src/gallium/auxiliary/tgsi/tgsi_scan.c
View file

@ -1029,11 +1029,12 @@ get_block_tessfactor_writemask(const struct tgsi_shader_info *info,
struct tgsi_full_instruction *inst;
unsigned writemask = 0;
do {
tgsi_parse_token(parse);
assert(parse->FullToken.Token.Type == TGSI_TOKEN_TYPE_INSTRUCTION);
inst = &parse->FullToken.FullInstruction;
check_no_subroutines(inst);
tgsi_parse_token(parse);
assert(parse->FullToken.Token.Type == TGSI_TOKEN_TYPE_INSTRUCTION);
inst = &parse->FullToken.FullInstruction;
check_no_subroutines(inst);
while (inst->Instruction.Opcode != end_opcode) {
/* Recursively process nested blocks. */
switch (inst->Instruction.Opcode) {
@ -1041,20 +1042,26 @@ get_block_tessfactor_writemask(const struct tgsi_shader_info *info,
case TGSI_OPCODE_UIF:
writemask |=
get_block_tessfactor_writemask(info, parse, TGSI_OPCODE_ENDIF);
continue;
break;
case TGSI_OPCODE_BGNLOOP:
writemask |=
get_block_tessfactor_writemask(info, parse, TGSI_OPCODE_ENDLOOP);
continue;
break;
case TGSI_OPCODE_BARRIER:
unreachable("nested BARRIER is illegal");
continue;
break;
default:
writemask |= get_inst_tessfactor_writemask(info, inst);
}
writemask |= get_inst_tessfactor_writemask(info, inst);
} while (inst->Instruction.Opcode != end_opcode);
tgsi_parse_token(parse);
assert(parse->FullToken.Token.Type == TGSI_TOKEN_TYPE_INSTRUCTION);
inst = &parse->FullToken.FullInstruction;
check_no_subroutines(inst);
}
return writemask;
}
@ -1068,18 +1075,20 @@ get_if_block_tessfactor_writemask(const struct tgsi_shader_info *info,
struct tgsi_full_instruction *inst;
unsigned then_tessfactor_writemask = 0;
unsigned else_tessfactor_writemask = 0;
unsigned writemask;
bool is_then = true;
do {
tgsi_parse_token(parse);
assert(parse->FullToken.Token.Type == TGSI_TOKEN_TYPE_INSTRUCTION);
inst = &parse->FullToken.FullInstruction;
check_no_subroutines(inst);
tgsi_parse_token(parse);
assert(parse->FullToken.Token.Type == TGSI_TOKEN_TYPE_INSTRUCTION);
inst = &parse->FullToken.FullInstruction;
check_no_subroutines(inst);
while (inst->Instruction.Opcode != TGSI_OPCODE_ENDIF) {
switch (inst->Instruction.Opcode) {
case TGSI_OPCODE_ELSE:
is_then = false;
continue;
break;
/* Recursively process nested blocks. */
case TGSI_OPCODE_IF:
@ -1088,28 +1097,33 @@ get_if_block_tessfactor_writemask(const struct tgsi_shader_info *info,
is_then ? &then_tessfactor_writemask :
&else_tessfactor_writemask,
cond_block_tf_writemask);
continue;
break;
case TGSI_OPCODE_BGNLOOP:
*cond_block_tf_writemask |=
get_block_tessfactor_writemask(info, parse, TGSI_OPCODE_ENDLOOP);
continue;
break;
case TGSI_OPCODE_BARRIER:
unreachable("nested BARRIER is illegal");
continue;
break;
default:
/* Process an instruction in the current block. */
writemask = get_inst_tessfactor_writemask(info, inst);
if (writemask) {
if (is_then)
then_tessfactor_writemask |= writemask;
else
else_tessfactor_writemask |= writemask;
}
}
/* Process an instruction in the current block. */
unsigned writemask = get_inst_tessfactor_writemask(info, inst);
if (writemask) {
if (is_then)
then_tessfactor_writemask |= writemask;
else
else_tessfactor_writemask |= writemask;
}
} while (inst->Instruction.Opcode != TGSI_OPCODE_ENDIF);
tgsi_parse_token(parse);
assert(parse->FullToken.Token.Type == TGSI_TOKEN_TYPE_INSTRUCTION);
inst = &parse->FullToken.FullInstruction;
check_no_subroutines(inst);
}
if (then_tessfactor_writemask || else_tessfactor_writemask) {
/* If both statements write the same tess factor channels,