From 4dad9d443b4554535a339dd4327e77498299b74a Mon Sep 17 00:00:00 2001 From: Lionel Landwerlin Date: Mon, 16 Jun 2025 14:51:01 +0300 Subject: [PATCH] anv: fix valgrind warning Found when running KHR-Single-GL46.arrays_of_arrays_gl.InteractionArgumentAliasing2_var_type_index_4 with zink/anv : Test case 'KHR-Single-GL46.arrays_of_arrays_gl.InteractionArgumentAliasing2_var_type_index_4'.. ==22722== Thread 3 glcts:zfq0: ==22722== Uninitialised byte(s) found during client check request ==22722== at 0x134A8D51: anv_batch_bo_finish (anv_batch_chain.c:350) ==22722== by 0x134ACD3E: anv_cmd_buffer_end_batch_buffer (anv_batch_chain.c:1114) ==22722== by 0x13CECB30: end_command_buffer (genX_cmd_buffer.c:3467) ==22722== by 0x13CECB7B: gfx12_EndCommandBuffer (genX_cmd_buffer.c:3478) ==22722== by 0x6FFA343: submit_queue (zink_batch.c:739) ==22722== by 0x672684B: util_queue_thread_func (u_queue.c:294) ==22722== by 0x6790976: impl_thrd_routine (threads_posix.c:43) ==22722== by 0x579BAA3: start_thread (pthread_create.c:447) ==22722== by 0x5828A33: clone (clone.S:100) ==22722== Address 0x94ac840 is 2,112 bytes inside a block of size 8,192 client-defined ==22722== at 0x134A04C7: anv_bo_pool_alloc (anv_allocator.c:1311) ==22722== by 0x134A8772: anv_batch_bo_create (anv_batch_chain.c:262) ==22722== by 0x134AB6BC: anv_cmd_buffer_init_batch_bo_chain (anv_batch_chain.c:877) ==22722== by 0x134BCC4C: anv_create_cmd_buffer (anv_cmd_buffer.c:146) ==22722== by 0x152FEBE4: vk_common_AllocateCommandBuffers (vk_command_pool.c:218) ==22722== by 0x133FEA1D: vkAllocateCommandBuffers (trampoline.c:1950) ==22722== by 0x6FF8AE4: create_batch_state (zink_batch.c:367) ==22722== by 0x6FF91B5: get_batch_state (zink_batch.c:495) ==22722== by 0x6FF91DB: zink_reset_batch (zink_batch.c:504) ==22722== by 0x6FF9424: zink_start_batch (zink_batch.c:537) ==22722== by 0x706C01D: zink_context_create (zink_context.c:5647) ==22722== by 0x60403A6: st_api_create_context (st_manager.c:978) ==22722== Signed-off-by: Lionel Landwerlin Fixes: d21e7e5a9f ("anv: Query sampler offset in set_image_clear_color()") Reviewed-by: Sagar Ghuge Reviewed-by: Dylan Baker Part-of: --- src/intel/vulkan/genX_cmd_buffer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 367ad625a4d..5e84b49d2bc 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/intel/vulkan/genX_cmd_buffer.c @@ -947,6 +947,8 @@ set_image_clear_color(struct anv_cmd_buffer *cmd_buffer, dw[4] = clear_color.u32[1]; dw[5] = clear_color.u32[2]; dw[6] = clear_color.u32[3]; + dw[7] = 0; + dw[8] = 0; dw[3 + sampler_offset / 4] = pixel[0]; dw[4 + sampler_offset / 4] = pixel[1]; #else