From 4d0975dc839ab4dd9b28b1dfa2bf65af4e9574a0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timur=20Krist=C3=B3f?= Date: Mon, 22 Dec 2025 13:31:03 -0600 Subject: [PATCH] radv: Update comments for gang semaphores MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change the explanation to use "leader" and "follower" terminology. Explain better how it is used with GFX/ACE and SDMA/ACE. Signed-off-by: Timur Kristóf Reviewed-by: Samuel Pitoiset Part-of: --- src/amd/vulkan/radv_cmd_buffer.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 5004d49305a..efa6e2ed224 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/src/amd/vulkan/radv_cmd_buffer.c @@ -1485,8 +1485,14 @@ radv_gang_sem_init(struct radv_cmd_buffer *cmd_buffer) if (cmd_buffer->gang.sem.va) return true; - /* DWORD 0: GFX->ACE semaphore (GFX blocks ACE, ie. ACE waits for GFX) - * DWORD 1: ACE->GFX semaphore + /* DWORD 0: + * leader->follower semaphore: used when leader does something that the follower has to wait for + * - for transfer queues: when SDMA is working on a transfer that ACE needs to wait for + * - for task/mesh: when GFX is doing something that ACE needs to wait for + * DWORD 1: + * follower->leader semaphore: used when follower does something that the leader has to wait for + * - for transfer queues: when ACE is working on a transfer that SDMA needs to wait for + * - for task/mesh: no needed yet */ uint64_t sem_init = 0; uint32_t va_off = 0;