From 4caf19eb7ddd4a416dde0bc764380a6a53756828 Mon Sep 17 00:00:00 2001 From: Samuel Pitoiset Date: Thu, 8 Apr 2021 19:16:04 +0200 Subject: [PATCH] radv: do not clamp framebuffer dimensions to the minimum dimension This shouldn't be needed and this is going to be wrong with VRS attachments because dimensions are divided by the VRS texel size. Signed-off-by: Samuel Pitoiset Reviewed-by: Bas Nieuwenhuizen Part-of: --- src/amd/vulkan/radv_device.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 2f56ae12798..bc594aa2123 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c @@ -7056,22 +7056,11 @@ VkResult radv_CreateFramebuffer( framebuffer->layers = pCreateInfo->layers; framebuffer->imageless = !!imageless_create_info; - if (imageless_create_info) { - for (unsigned i = 0; i < imageless_create_info->attachmentImageInfoCount; ++i) { - const VkFramebufferAttachmentImageInfo *attachment = - imageless_create_info->pAttachmentImageInfos + i; - framebuffer->width = MIN2(framebuffer->width, attachment->width); - framebuffer->height = MIN2(framebuffer->height, attachment->height); - framebuffer->layers = MIN2(framebuffer->layers, attachment->layerCount); - } - } else { + if (!imageless_create_info) { for (uint32_t i = 0; i < pCreateInfo->attachmentCount; i++) { VkImageView _iview = pCreateInfo->pAttachments[i]; struct radv_image_view *iview = radv_image_view_from_handle(_iview); framebuffer->attachments[i] = iview; - framebuffer->width = MIN2(framebuffer->width, iview->extent.width); - framebuffer->height = MIN2(framebuffer->height, iview->extent.height); - framebuffer->layers = MIN2(framebuffer->layers, radv_surface_max_layer_count(iview)); } }