fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-04 16:18:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

r300: be more agressive when merging A0 loads

Browse source 
Specifically we would bail out previously when encountering any
control flow, now we would optimize it even when the second ARL/ARR
is inside a lower level if/else branch.

shader-db

RV530:
total instructions in shared programs: 132020 -> 131924 (-0.07%)
instructions in affected programs: 3374 -> 3278 (-2.85%)
helped: 4
HURT: 0

RV370:
no change (no control flow there)

Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Filip Gawin <filip.gawin@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23560>
This commit is contained in:
Pavel Ondračka 2023-06-07 15:48:00 +02:00 • committed by Marge Bot
parent 6de9152e3a
commit 4c28c5b074
1 changed files with 24 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/gallium/drivers/r300/compiler/radeon_optimize.c
View file

@ -1345,6 +1345,7 @@ static void merge_A0_loads(
unsigned int A0_src_reg = inst->U.I.SrcReg[0].Index;
unsigned int A0_src_file = inst->U.I.SrcReg[0].File;
unsigned int A0_src_swizzle = inst->U.I.SrcReg[0].Swizzle;
int cf_depth = 0;
struct rc_instruction * cur = inst;
while (cur != &c->Program.Instructions) {
@ -1352,10 +1353,30 @@ static void merge_A0_loads(
const struct rc_opcode_info * opcode = rc_get_opcode_info(cur->U.I.Opcode);
/* Keep it simple for now and stop when encountering any
* control flow.
* control flow besides simple ifs.
*/
if (opcode->IsFlowControl)
return;
if (opcode->IsFlowControl) {
switch (cur->U.I.Opcode) {
case RC_OPCODE_IF:
{
cf_depth++;
break;
}
case RC_OPCODE_ELSE:
{
if (cf_depth < 1)
return;
break;
}
case RC_OPCODE_ENDIF:
{
cf_depth--;
break;
}
default:
return;
}
}
/* Stop when the original source is overwritten */
if (A0_src_reg == cur->U.I.DstReg.Index &&