From 4c2356f13cb199dad474d38fecd424d200e4cffd Mon Sep 17 00:00:00 2001 From: Francisco Jerez Date: Thu, 20 Apr 2017 11:42:27 -0700 Subject: [PATCH] intel/fs: Take into account amount of data read in spilling cost heuristic. Until now the spilling cost calculation was neglecting the amount of data read from the register during the spilling cost calculation. This caused it to make suboptimal decisions in some cases leading to higher memory bandwidth usage than necessary. Improves Unigine Heaven performance by ~4% on BDW, reversing an unintended FPS regression from my previous commit 147e71242ce539ff28e282f009c332818c35f5ac with n=12 and statistical significance 5%. In addition SynMark2 OglCSDof performance is improved by an additional ~5% on SKL, and a Kerbal Space Program apitrace around the Moho planet I can provide on request improves by ~20%. Cc: Reviewed-by: Plamena Manolova Reviewed-by: Jason Ekstrand (cherry picked from commit 58324389be7bc7c5e10093b9cc0a8efa9b4c93a9) [Andres Gomez: resolve trivial conflicts] Signed-off-by: Andres Gomez Conflicts: src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp --- src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp b/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp index 6ede65a1f59..12a39acebef 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp +++ b/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp @@ -822,7 +822,7 @@ fs_visitor::choose_spill_reg(struct ra_graph *g) foreach_block_and_inst(block, fs_inst, inst, cfg) { for (unsigned int i = 0; i < inst->sources; i++) { if (inst->src[i].file == VGRF) - spill_costs[inst->src[i].nr] += loop_scale; + spill_costs[inst->src[i].nr] += regs_read(inst, i) * loop_scale; } if (inst->dst.file == VGRF)