fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 15:20:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

pan/bi: Validate preload constraints are satisfied

Browse source 
We tightened the rules around preloading substantially and take advantage of the
rules in RA. The safe helpers it introduced should ensure the rules are
followed, but just in case, add a validation pass to check our work. This pass
found (multiple) bugs in early versions of this series.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16585>
This commit is contained in:
Alyssa Rosenzweig 2022-05-11 15:47:39 -04:00 • committed by Marge Bot
parent 3636cddde1
commit 4c1bb23a86
1 changed files with 56 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

56
src/panfrost/bifrost/bi_validate.c
View file

@ -53,6 +53,57 @@ bi_validate_initialization(bi_context *ctx)
return success;
}
/*
* Validate that there are no bi_registers accessed except at the beginning of
* the start block, and that preloads are unique. This ensures RA can coalesce
* preloads without interference tracking.
*/
static bool
bi_validate_preload(bi_context *ctx)
{
bool start = true;
uint64_t preloaded = 0;
bi_foreach_block(ctx, block) {
bi_foreach_instr_in_block(block, I) {
/* No instruction should have a register destination */
bi_foreach_dest(I, d) {
if (I->dest[d].type == BI_INDEX_REGISTER)
return false;
}
/* Preloads are register moves at the start */
bool is_preload =
start && I->op == BI_OPCODE_MOV_I32 &&
I->src[0].type == BI_INDEX_REGISTER;
/* After the first nonpreload, we're done preloading */
start &= is_preload;
/* Only preloads may have a register source */
bi_foreach_src(I, s) {
if (I->src[s].type == BI_INDEX_REGISTER && !is_preload)
return false;
}
/* Check uniqueness */
if (is_preload) {
unsigned r = I->src[0].value;
if (preloaded & BITFIELD64_BIT(r))
return false;
preloaded |= BITFIELD64_BIT(r);
}
}
/* Only the first block may preload */
start = false;
}
return true;
}
void
bi_validate(bi_context *ctx, const char *after)
{
@ -66,6 +117,11 @@ bi_validate(bi_context *ctx, const char *after)
fail = true;
}
if (!bi_validate_preload(ctx)) {
fprintf(stderr, "Unexpected preload after %s\n", after);
fail = true;
}
/* TODO: Validate more invariants */
if (fail) {