fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 19:58:09 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

radv: remove RADV_DEBUG=nogsfastlaunch2

Browse source 
It's been two Mesa releases since this fast-launch mode2 has been fixed
on GFX11 and everything works as expected. The option is no longer
needed, note that GFX12 only has mode2 apparently.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30815>
This commit is contained in:
Samuel Pitoiset 2024-08-23 14:36:58 +02:00 • committed by Marge Bot
parent 4a8f3181ba
commit 4c1a912372
5 changed files with 3 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
docs/envvars.rst
View file

@ -1366,8 +1366,6 @@ RADV driver environment variables
disable FMASK compression on MSAA images (GFX6-GFX10.3)
``nogpl``
disable VK_EXT_graphics_pipeline_library
``nogsfastlaunch2``
disable GS_FAST_LAUNCH=2 for Mesh shaders (GFX11 only)
``nohiz``
disable HIZ for depthstencil images
``noibs``

5
src/amd/vulkan/radv_debug.h
View file

@ -57,9 +57,8 @@ enum {
RADV_DEBUG_NO_RT = 1ull << 41,
RADV_DEBUG_NO_MESH_SHADER = 1ull << 42,
RADV_DEBUG_NO_NGG_GS = 1ull << 43,
RADV_DEBUG_NO_GS_FAST_LAUNCH_2 = 1ull << 44,
RADV_DEBUG_NO_ESO = 1ull << 45,
RADV_DEBUG_PSO_CACHE_STATS = 1ull << 46,
RADV_DEBUG_NO_ESO = 1ull << 44,
RADV_DEBUG_PSO_CACHE_STATS = 1ull << 45,
};
enum {

1
src/amd/vulkan/radv_instance.c
View file

@ -70,7 +70,6 @@ static const struct debug_control radv_debug_options[] = {{"nofastclears", RADV_
{"nort", RADV_DEBUG_NO_RT},
{"nomeshshader", RADV_DEBUG_NO_MESH_SHADER},
{"nongg_gs", RADV_DEBUG_NO_NGG_GS},
{"nogsfastlaunch2", RADV_DEBUG_NO_GS_FAST_LAUNCH_2},
{"noeso", RADV_DEBUG_NO_ESO},
{"psocachestats", RADV_DEBUG_PSO_CACHE_STATS},
{NULL, 0}};

5
src/amd/vulkan/radv_physical_device.c
View file

@ -165,7 +165,6 @@ radv_physical_device_init_cache_key(struct radv_physical_device *pdev)
key->ge_wave32 = pdev->ge_wave_size == 32;
key->invariant_geom = !!(instance->debug_flags & RADV_DEBUG_INVARIANT_GEOM);
key->lower_discard_to_demote = !!(instance->debug_flags & RADV_DEBUG_DISCARD_TO_DEMOTE);
key->mesh_fast_launch_2 = pdev->mesh_fast_launch_2;
key->no_fmask = !!(instance->debug_flags & RADV_DEBUG_NO_FMASK);
key->no_ngg_gs = !!(instance->debug_flags & RADV_DEBUG_NO_NGG_GS);
key->no_rt = !!(instance->debug_flags & RADV_DEBUG_NO_RT);
@ -2098,9 +2097,7 @@ radv_physical_device_try_create(struct radv_instance *instance, drmDevicePtr drm
pdev->emulate_ngg_gs_query_pipeline_stat = pdev->use_ngg && pdev->info.gfx_level < GFX11;
pdev->mesh_fast_launch_2 =
(pdev->info.gfx_level >= GFX11 && !(instance->debug_flags & RADV_DEBUG_NO_GS_FAST_LAUNCH_2)) ||
pdev->info.gfx_level >= GFX12;
pdev->mesh_fast_launch_2 = pdev->info.gfx_level >= GFX11;
pdev->emulate_mesh_shader_queries = pdev->info.gfx_level == GFX10_3;

1
src/amd/vulkan/radv_physical_device.h
View file

@ -55,7 +55,6 @@ struct radv_physical_device_cache_key {
uint32_t ge_wave32 : 1;
uint32_t invariant_geom : 1;
uint32_t lower_discard_to_demote : 1;
uint32_t mesh_fast_launch_2 : 1;
uint32_t no_fmask : 1;
uint32_t no_ngg_gs : 1;
uint32_t no_rt : 1;