From 4c080cb8e50cde3f41120f4bd85177bcb47f3f56 Mon Sep 17 00:00:00 2001 From: Simon Ser Date: Wed, 19 Oct 2022 10:27:01 +0200 Subject: [PATCH] egl: fix error string for dri2_create_image_dma_buf() Using dri2_create_image_khr_texture_error() here prints an error like so: command: eglCreateImageKHR, error: EGL_BAD_ALLOC (0x3003), message: "dri2_create_image_khr_texture" This is confusing, because dri2_create_image_khr_texture() is unrelated to this error. Instead, print a more accurate error manually. Signed-off-by: Simon Ser Reviewed-by: Eric Engestrom Part-of: --- src/egl/drivers/dri2/egl_dri2.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index afe9a9c97f1..023c56cdb26 100644 --- a/src/egl/drivers/dri2/egl_dri2.c +++ b/src/egl/drivers/dri2/egl_dri2.c @@ -2946,6 +2946,7 @@ dri2_create_image_dma_buf(_EGLDisplay *disp, _EGLContext *ctx, uint64_t modifier; bool has_modifier = false; unsigned error; + EGLint egl_error; /** * The spec says: @@ -3033,7 +3034,10 @@ dri2_create_image_dma_buf(_EGLDisplay *disp, _EGLContext *ctx, &error, NULL); } - dri2_create_image_khr_texture_error(error); + + egl_error = egl_error_from_dri_image_error(error); + if (egl_error != EGL_SUCCESS) + _eglError(egl_error, "createImageFromDmaBufs failed"); if (!dri_image) return EGL_NO_IMAGE_KHR;