From 4c06c736c56454451f9a7c495ed287e9b74b7f4a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Roberto=20de=20Souza?= Date: Mon, 14 Aug 2023 14:00:27 -0700 Subject: [PATCH] intel/isl: Remove unknown workaround MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The way this workaround is implemented, it is being applied to all gfx 12 platforms(TGL, ADL, RKL, RPL, DG1, DG2 and MTL) but it was supposed to be fixed in TGL B0. Unfortunately I did not found any workaround number that would match it. But as all released platforms don't ship to customers with revision == 0 this workaround was never being applied and can be safely removed. Signed-off-by: José Roberto de Souza Reviewed-by: Sagar Ghuge Part-of: --- src/intel/isl/isl_surface_state.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/src/intel/isl/isl_surface_state.c b/src/intel/isl/isl_surface_state.c index f5d9913d652..203d78c0ded 100644 --- a/src/intel/isl/isl_surface_state.c +++ b/src/intel/isl/isl_surface_state.c @@ -928,25 +928,6 @@ isl_genX(buffer_fill_state_s)(const struct isl_device *dev, void *state, s.Depth = ((num_elements - 1) >> 20) & 0x7f; #endif - if (GFX_VER == 12 && dev->info->revision == 0) { - /* TGL-LP A0 has a HW bug (fixed in later HW) which causes buffer - * textures with very close base addresses (delta < 64B) to corrupt each - * other. We can sort-of work around this by making small buffer - * textures 1D textures instead. This doesn't fix the problem for large - * buffer textures but the liklihood of large, overlapping, and very - * close buffer textures is fairly low and the point is to hack around - * the bug so we can run apps and tests. - */ - if (info->format != ISL_FORMAT_RAW && - info->stride_B == isl_format_get_layout(info->format)->bpb / 8 && - num_elements <= (1 << 14)) { - s.SurfaceType = SURFTYPE_1D; - s.Width = num_elements - 1; - s.Height = 0; - s.Depth = 0; - } - } - #if GFX_VER >= 6 s.NumberofMultisamples = MULTISAMPLECOUNT_1; #endif