fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-27 16:38:12 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

anv: Allow CCS on more storage images for gfx12.5

Browse source 
To do this, we use a heuristic that depends on the image format and size
(see HSD 18014810884).

Average of two runs on an A750 from the performance CI:

* Naraka    +0.89%
* TWWH3     +0.45%
* Control   +0.37%
* Cyberpunk +0.35%

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41034>
This commit is contained in:
Nanley Chery 2026-04-16 12:54:06 -04:00 • committed by Marge Bot
parent df446326f8
commit 4b9561c733
1 changed files with 23 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/intel/vulkan/anv_image.c
View file

@ -518,7 +518,7 @@ anv_formats_ccs_e_compatible(const struct anv_physical_device *physical_device,
if (vk_usage & VK_IMAGE_USAGE_STORAGE_BIT) {
/* Only color */
assert((vk_format_aspects(vk_format) & ~VK_IMAGE_ASPECT_ANY_COLOR_BIT_ANV) == 0);
if (devinfo->ver == 12) {
if (devinfo->verx10 == 120) {
/* From the TGL Bspec 44930 (r47128):
*
* "Memory atomic operation on compressed data is not supported
@ -528,9 +528,7 @@ anv_formats_ccs_e_compatible(const struct anv_physical_device *physical_device,
* Software should ensure at the time of the Atomic operation
* the surface is resolved (uncompressed) state."
*
* On gfx12.0, compression is not supported with atomic
* operations. On gfx12.5, the support is there, but it's slow
* (see HSD 1406337848).
* On gfx12.0, compression is not supported with atomic operations.
*
* We only care about the non-modifier case. Modifier capabilities
* are exposed via the standard interfaces and unlike prior
@ -2023,6 +2021,27 @@ anv_image_init(struct anv_device *device, struct anv_image *image,
isl_extra_usage_flags |= ISL_SURF_USAGE_DISABLE_AUX_BIT;
}
if (device->info->verx10 == 125 &&
image->vk.tiling != VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT &&
(image->vk.usage & VK_IMAGE_USAGE_STORAGE_BIT) &&
(image->vk.format == VK_FORMAT_R32_UINT ||
image->vk.format == VK_FORMAT_R32_SINT) &&
image->vk.extent.width * image->vk.extent.height <= 16384 * 127) {
/* According to HSD 1406337848, atomics are slow on compressed
* surfaces. To mitigate this, HSD 18014810884 suggests disabling CCS
* if the total size of every pixel in the image is <= 64KB. In order
* to avoid trace regressions, we implement a stricter size check.
* This upper limit specifically avoids regressions from 1080p images
* in a Sons of the Forest trace.
*
* Note that atomics on the compressed modifiers are disabled through
* format queries. So, we ignore that tiling here.
*/
anv_perf_warn(VK_LOG_OBJS(&image->vk.base),
"Disabling aux: atomics are slow with CCS");
isl_extra_usage_flags |= ISL_SURF_USAGE_DISABLE_AUX_BIT;
}
if (device->info->ver >= 12 &&
!anv_formats_ccs_e_compatible(device->physical,
image->vk.create_flags,