fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 02:38:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

panvk: do not enable extension without required feature

Browse source 
The Vulkan spec states that if VK_ARM_shader_core_builtins is supported,
shaderCoreBuiltins is a required feature. So let's not enable that
extension unless we can...

Fixes: dff1d91c64 ("panvk: Enable VK_ARM_shader_core_builtins")
Reviewed-by: Daniel Stone <daniels@collabora.com>
(cherry picked from commit 8cb89853b8)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41104>
This commit is contained in:
Erik Faye-Lund 2026-04-17 15:31:16 +02:00 • committed by Eric Engestrom
parent bf1c7cd431
commit 4b5a101e0a
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -1144,7 +1144,7 @@
"description": "panvk: do not enable extension without required feature",
"nominated": true,
"nomination_type": 2,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "dff1d91c64e55541174141b528d90a7aeab9b0da",
"notes": null

2
docs/features.txt
View file

@ -721,7 +721,7 @@ Khronos extensions that are not part of any Vulkan version:
VK_ANDROID_native_buffer DONE (anv, lvp, panvk, radv, tu, v3dv, vn)
VK_ARM_rasterization_order_attachment_access DONE (lvp, tu, vn)
VK_ARM_scheduling_controls DONE (panvk/v10+)
VK_ARM_shader_core_builtins DONE (panvk)
VK_ARM_shader_core_builtins DONE (panvk/v9+)
VK_ARM_shader_core_properties DONE (panvk/v10+)
VK_GOOGLE_decorate_string DONE (anv, hasvk, hk, kk, lvp, nvk, panvk, radv, tu, vn)
VK_GOOGLE_hlsl_functionality1 DONE (anv, hasvk, hk, kk, lvp, nvk, panvk, radv, tu, vn)

2
src/panfrost/vulkan/panvk_vX_physical_device.c
View file

@ -221,7 +221,7 @@ panvk_per_arch(get_physical_device_extensions)(
.VALVE_mutable_descriptor_type = PAN_ARCH >= 9,
.ARM_shader_core_builtins = true,
.ARM_shader_core_builtins = PAN_ARCH >= 9,
.ARM_shader_core_properties = has_vk1_1,
.ARM_scheduling_controls = PAN_ARCH >= 10,
};