From 4b49241f7d731f01582ea622d33f6afdc03b48af Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Fri, 21 Oct 2022 11:43:15 -0400 Subject: [PATCH] panfrost: Use proper formats for pntc varying The formats of special attributes are supposed to match their architectural definitions, and point coordinates are architecturally defined as RGBA32F. In practice this doesn't seem to fix anything. Cc: mesa-stable Signed-off-by: Alyssa Rosenzweig Part-of: --- src/gallium/drivers/panfrost/pan_cmdstream.c | 2 +- src/panfrost/ci/traces-panfrost.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_cmdstream.c b/src/gallium/drivers/panfrost/pan_cmdstream.c index 02ca55398df..f34520ddec3 100644 --- a/src/gallium/drivers/panfrost/pan_cmdstream.c +++ b/src/gallium/drivers/panfrost/pan_cmdstream.c @@ -2387,7 +2387,7 @@ static const struct { } pan_varying_formats[PAN_VARY_MAX] = { [PAN_VARY_POSITION] = { 4, MALI_SNAP_4 }, [PAN_VARY_PSIZ] = { 1, MALI_R16F }, - [PAN_VARY_PNTCOORD] = { 1, MALI_R16F }, + [PAN_VARY_PNTCOORD] = { 4, MALI_RGBA32F }, [PAN_VARY_FACE] = { 1, MALI_R32I }, [PAN_VARY_FRAGCOORD] = { 4, MALI_RGBA32F }, }; diff --git a/src/panfrost/ci/traces-panfrost.yml b/src/panfrost/ci/traces-panfrost.yml index 533a4352f4e..968135e633d 100644 --- a/src/panfrost/ci/traces-panfrost.yml +++ b/src/panfrost/ci/traces-panfrost.yml @@ -179,7 +179,7 @@ traces: neverball/neverball-v2.trace: gl-panfrost-t860: label: [broken] - checksum: 12c8f3af1ed07b939b5e1de8067e5edd + checksum: 53365059f3b84436c199f1cb6f6d3b35 text: Missing the coins and the texture on the "Nev" of the level. paraview/pv-manyspheres-v2.trace: gl-panfrost-t860: