From 48f0d738deb27795c801e700b310df4ab0837eb3 Mon Sep 17 00:00:00 2001 From: Faith Ekstrand Date: Tue, 10 Jun 2025 14:15:29 -0400 Subject: [PATCH] nvk: Don't set queue lost from nvk_queue_push() This is used both in the vkQueueSubmit path and in the vkCreateDevice path and we don't want vkCreateDevice to return VK_ERROR_DEVICE_LOST. In the vkQueueSubmit path we already have a catch-all that will cause device loss on any error so we don't need to do it in nvk_queue_push(). This fixes dEQP-VK.api.device_init.create_instance_device_intentional_alloc_fail.basic Fixes: e814fc16ff60 ("nvk: Use an nvk_mem_stream for nvk_queue_push()") Part-of: --- src/nouveau/vulkan/nvk_queue.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/nouveau/vulkan/nvk_queue.c b/src/nouveau/vulkan/nvk_queue.c index 912e9d7d833..31613f244aa 100644 --- a/src/nouveau/vulkan/nvk_queue.c +++ b/src/nouveau/vulkan/nvk_queue.c @@ -343,10 +343,7 @@ nvk_queue_push(struct nvk_queue *queue, const struct nv_push *push) (pdev->debug_flags & NVK_DEBUG_PUSH_DUMP)) vk_push_print(stderr, push, &pdev->info); - if (result != VK_SUCCESS) - return vk_queue_set_lost(&queue->vk, "Submit failed"); - - return VK_SUCCESS; + return result; } static VkResult