fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-21 05:00:09 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

bin/ci: crnm: bug stress mode retry formula

Browse source 
The execution_times structure was filled the same way in all the cases of an
if. As a side effect, the retry evaluation doesn't include the last result and
can lead, as a race condition, into triggering one extra time than the
indication in the stress argument.

Signed-off-by: Sergi Blanch Torne <sergi.blanch.torne@collabora.com>
Reviewed-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33750>
This commit is contained in:
Sergi Blanch Torne 2025-04-17 23:50:01 +02:00 • committed by Marge Bot
parent e6843c1705
commit 48bccb7d55
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
bin/ci/ci_run_n_monitor.py
View file

@ -122,17 +122,16 @@ def run_target_job(
target_statuses: dict, target_statuses: dict,
name_field_pad: int, name_field_pad: int,
) -> None: ) -> None:
execution_times[job.name][job.id] = (job_duration(job), job.status, job.web_url)
if stress and job.status in COMPLETED_STATUSES: if stress and job.status in COMPLETED_STATUSES:
if ( if (
stress < 0 stress < 0
or len(execution_times[job.name]) < stress or len(execution_times[job.name]) < stress
): ):
execution_times[job.name][job.id] = (job_duration(job), job.status, job.web_url)
enable_job_fn(job=job, action_type="retry") enable_job_fn(job=job, action_type="retry")
# Wait for the next loop to get the updated job object # Wait for the next loop to get the updated job object
return return
else: else:
execution_times[job.name][job.id] = (job_duration(job), job.status, job.web_url)
enable_job_fn(job=job, action_type="target") enable_job_fn(job=job, action_type="target")
print_job_status(job, job.status not in target_statuses[job.name], name_field_pad) print_job_status(job, job.status not in target_statuses[job.name], name_field_pad)