fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-30 22:20:27 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

brw/scoreboard: Use a predicate helper for the nomask workaround

Browse source 
If it wasn't for the workaround, it wouldn't be necessary to track the
whether instructions are exec_all or not.  The workaround affects
results when mixing a dep and inst with different exec_all.

Add the predicate so that, when the workaround is disabled, none of
the effects of having different exec_all will kick in, all them will
be considered `exec_all = true`.

This patch don't change any behavior, just adds the predicate.

Reviewed-by: Francisco Jerez <currojerez@riseup.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36659>
This commit is contained in:
Caio Oliveira 2025-08-06 22:32:48 -07:00 • committed by Marge Bot
parent 6fc211335a
commit 47a6ef3fef
1 changed files with 16 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/intel/compiler/brw/brw_lower_scoreboard.cpp
View file

@ -854,6 +854,16 @@ namespace {
unsigned n;
};
/**
* Whether it is needed to apply workaround to avoid
* data coherency issues due to Wa_1407528679.
*/
bool
needs_nomask_workaround(const intel_device_info *devinfo)
{
return true;
}
/**
* Add dependency \p dep to the list of dependencies of an instruction
* \p deps.
@ -983,7 +993,8 @@ namespace {
const dependency_list &deps,
const ordered_address &jp)
{
const bool exec_all = inst->force_writemask_all;
const bool exec_all = inst->force_writemask_all ||
!needs_nomask_workaround(devinfo);
const bool has_ordered = find_ordered_dependency(deps, jp, exec_all);
const tgl_pipe ordered_pipe = ordered_dependency_swsb(deps, jp,
exec_all).pipe;
@ -1224,7 +1235,8 @@ namespace {
unsigned ip = 0;
foreach_block_and_inst(block, brw_inst, inst, shader->cfg) {
const bool exec_all = inst->force_writemask_all;
const bool exec_all = inst->force_writemask_all ||
!needs_nomask_workaround(devinfo);
const tgl_pipe p = inferred_exec_pipe(devinfo, inst);
scoreboard &sb = sbs[block->num];
@ -1377,7 +1389,8 @@ namespace {
unsigned ip = 0;
foreach_block_and_inst_safe(block, brw_inst, inst, shader->cfg) {
const bool exec_all = inst->force_writemask_all;
const bool exec_all = inst->force_writemask_all ||
!needs_nomask_workaround(devinfo);
const bool ordered_mode =
baked_ordered_dependency_mode(devinfo, inst, deps[ip], jps[ip]);
const tgl_sbid_mode unordered_mode =