fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-21 18:00:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

iris/icl+: Report same caching domain as main surface for clear color BO.

Browse source 
Even though the clear color BO is bound as a read-only buffer, report
the same caching domain as the main BO in use_surface() (typically
IRIS_DOMAIN_RENDER_WRITE) in order to avoid ping-ponging back and
forth between IRIS_DOMAIN_RENDER_WRITE and IRIS_DOMAIN_OTHER_READ,
which leads to increased stall-at-pixel-scoreboard synchronization
between draw calls.

Fixes a 5%-10% FPS regression in some benchmarks spotted on ICL.

Reported-by: Clayton Craft <clayton.a.craft@intel.com>
Fixes: eb5d1c2722 "iris: Annotate all BO uses with domain and sequence number information."
Closes: #3097
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5411>
This commit is contained in:
Francisco Jerez 2020-06-09 15:23:30 -07:00
parent 7afdc549f4
commit 479249bce6
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/gallium/drivers/iris/iris_state.c
View file

@ -4641,8 +4641,7 @@ use_surface(struct iris_context *ice,
if (res->aux.bo) { if (res->aux.bo) {
iris_use_pinned_bo(batch, res->aux.bo, writeable, access); iris_use_pinned_bo(batch, res->aux.bo, writeable, access);
if (res->aux.clear_color_bo) if (res->aux.clear_color_bo)
iris_use_pinned_bo(batch, res->aux.clear_color_bo, iris_use_pinned_bo(batch, res->aux.clear_color_bo, false, access);
false, IRIS_DOMAIN_OTHER_READ);
if (memcmp(&res->aux.clear_color, &surf->clear_color, if (memcmp(&res->aux.clear_color, &surf->clear_color,
sizeof(surf->clear_color)) != 0) { sizeof(surf->clear_color)) != 0) {