From 47831969c8dd9b6cba758e8326a2220c147e6ac0 Mon Sep 17 00:00:00 2001
From: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Date: Mon, 23 May 2022 13:13:16 -0400
Subject: [PATCH] asahi: Split up unk 2b

Seems to be flags.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18380>
---
 src/asahi/lib/cmdbuf.xml              | 5 ++++-
 src/gallium/drivers/asahi/agx_state.c | 7 ++++---
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/asahi/lib/cmdbuf.xml b/src/asahi/lib/cmdbuf.xml
index de199124fb5..a65395669db 100644
--- a/src/asahi/lib/cmdbuf.xml
+++ b/src/asahi/lib/cmdbuf.xml
@@ -461,7 +461,10 @@
     <field name="Tag" size="8" start="0:0" type="hex" default="0x4d"/>
     <field name="Unk 1" size="24" start="0:8" type="hex" default="0x2010bd"/>
     <field name="Unk 2" size="8" start="1:0" type="hex" default="0x0d"/>
-    <field name="Unk 2b" size="8" start="1:8" type="uint" default="5"/> <!-- 1 for other frag, 5 with discard? -->
+    <field name="Unk 1 8" size="1" start="1:8" type="bool" default="0"/>
+    <field name="Unk 1 9" size="1" start="1:9" type="bool" default="0"/>
+    <field name="Unk 1 10" size="1" start="1:10" type="bool" default="0"/>
+    <field name="Unk 1 11" size="1" start="1:10" type="bool" default="0"/>
     <field name="Code" size="32" start="1:16" type="address"/>
     <field name="Unk 3" size="8" start="2:16" type="hex" default="0x28d"/>
     <field name="Register quadwords" size="5" start="2:24" type="uint"/> <!-- 0 for max -->
diff --git a/src/gallium/drivers/asahi/agx_state.c b/src/gallium/drivers/asahi/agx_state.c
index 514346bd712..23c18b1de65 100644
--- a/src/gallium/drivers/asahi/agx_state.c
+++ b/src/gallium/drivers/asahi/agx_state.c
@@ -1238,7 +1238,8 @@ agx_build_pipeline(struct agx_context *ctx, struct agx_compiled_shader *cs, enum
          cfg.unk_3 = 0x8d;
          cfg.unk_1 = 0x2010bd;
          cfg.unk_2 = 0x0d;
-         cfg.unk_2b = writes_sample_mask ? 5 : 1;
+         cfg.unk_1_8 = 1;
+         cfg.unk_1_10 = writes_sample_mask;
          cfg.fragment_parameters.early_z_testing = !writes_sample_mask;
          cfg.unk_3b = 0x1;
          cfg.unk_4 = 0x800;
@@ -1289,7 +1290,7 @@ agx_build_clear_pipeline(struct agx_context *ctx, uint32_t code, uint64_t clear_
       cfg.register_quadwords = 1;
       cfg.unk_3 = 0x8d;
       cfg.unk_2 = 0x0d;
-      cfg.unk_2b = 4;
+      cfg.unk_1_10 = true;
       cfg.fragment_parameters.unk_1 = 0x880100;
       cfg.fragment_parameters.early_z_testing = false;
       cfg.fragment_parameters.unk_2 = false;
@@ -1382,7 +1383,7 @@ agx_build_reload_pipeline(struct agx_context *ctx, uint32_t code, struct pipe_su
       cfg.register_quadwords = 0;
       cfg.unk_3 = 0x8d;
       cfg.unk_2 = 0x0d;
-      cfg.unk_2b = 4;
+      cfg.unk_1_10 = 4;
       cfg.unk_4 = 0;
       cfg.fragment_parameters.unk_1 = 0x880100;
       cfg.fragment_parameters.early_z_testing = false;