From 4734048d516b96272539d8f760d60d4de9d55875 Mon Sep 17 00:00:00 2001 From: David Heidelberg Date: Thu, 3 Nov 2022 17:48:26 +0100 Subject: [PATCH] ci/update_traces_checksum.py: check if checksum is in the array, not it's value Fixes: 45eda069531a ("ci: introduce update_traces_checksum.py") Reviewed-by: Guilherme Gallo Signed-off-by: David Heidelberg Part-of: (cherry picked from commit e1d40d11f5a6083c19582c2e138f453cc2c7d4e4) --- .gitlab-ci/bin/update_traces_checksum.py | 5 +---- .pick_status.json | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/.gitlab-ci/bin/update_traces_checksum.py b/.gitlab-ci/bin/update_traces_checksum.py index 54c84c1bf64..55cb1b72f00 100755 --- a/.gitlab-ci/bin/update_traces_checksum.py +++ b/.gitlab-ci/bin/update_traces_checksum.py @@ -90,10 +90,7 @@ def gather_results( print(f"Trace {trace} crashed") continue - if ( - checksum in target['traces'][trace][dev_name] and - target['traces'][trace][dev_name]['checksum'] == checksum - ): + if target['traces'][trace][dev_name].get('checksum') == checksum: continue if "label" in target['traces'][trace][dev_name]: diff --git a/.pick_status.json b/.pick_status.json index f409e4a05ac..f738a44e3d1 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -1471,7 +1471,7 @@ "description": "ci/update_traces_checksum.py: check if checksum is in the array, not it's value", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "45eda069531adf17d28538696ace5dfcbc9ad230" },