fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 21:50:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

freedreno/ir3: disable cp for indirect src's

Browse source 
The variable-indexing tests always had a few random fails, which I
usually couldn't reproduce when running tests manually.  Somehow
recently this got a lot worse.  I ported a couple of the shaders to
GLES to see what blob does, and it also seems to be avoiding to cp
indirect srcs.  So I guess indirect w/ instructions other than cat1
(mov) are not totally reliable.  Let's just switch that off until
this is better understood.

Signed-off-by: Rob Clark <robclark@freedesktop.org>
This commit is contained in:
Rob Clark 2016-05-23 15:53:23 -04:00
parent c3c4370299
commit 46ff17559b
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/gallium/drivers/freedreno/ir3/ir3_cp.c
View file

@ -102,6 +102,15 @@ static bool valid_flags(struct ir3_instruction *instr, unsigned n,
(flags & IR3_REG_RELATIV))
return false;
/* TODO it seems to *mostly* work to cp RELATIV, except we get some
* intermittent piglit variable-indexing fails. Newer blob driver
* doesn't seem to cp these. Possibly this is hw workaround? Not
* sure, but until that is understood better, lets just switch off
* cp for indirect src's:
*/
if (flags & IR3_REG_RELATIV)
return false;
/* clear flags that are 'ok' */
switch (opc_cat(instr->opc)) {
case 1: