From 46764815ac39dc2ea22417963d5b5be5e420bee1 Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Tue, 6 Jun 2023 23:34:31 -0700 Subject: [PATCH] tu: Fix missing unlock Fix defect reported by Coverity Scan. Missing unlock (LOCK) missing_unlock: Returning without unlocking dev->vma_mutex. Fixes: c20139c2922 ("tu: Enable bufferDeviceAddressCaptureReplay") Signed-off-by: Vinson Lee Part-of: --- src/freedreno/vulkan/tu_knl_drm_msm.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/freedreno/vulkan/tu_knl_drm_msm.cc b/src/freedreno/vulkan/tu_knl_drm_msm.cc index 25ae2223fc4..d093f57263d 100644 --- a/src/freedreno/vulkan/tu_knl_drm_msm.cc +++ b/src/freedreno/vulkan/tu_knl_drm_msm.cc @@ -395,6 +395,7 @@ tu_allocate_userspace_iova(struct tu_device *dev, util_vma_heap_alloc_addr(&dev->vma, client_iova, size)) { *iova = client_iova; } else { + mtx_unlock(&dev->vma_mutex); return VK_ERROR_INVALID_OPAQUE_CAPTURE_ADDRESS; } }