fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-25 00:00:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix vertex cache bug that allows multiple vertices to fall into the same slot.

Browse source 
Need to set the slot's bit in draw->vcache.referenced even when there was a
cache hit since flushing the primitive buffer will have cleared the bitfield
but not the cache's vertex indexes.

Fixes a bug found when drawing long triangle fans but could be hit by other
prim types as well.

An alternate fix would be to call draw_vertex_cache_invalidate() from
draw_vertex_cache_unreference().
This commit is contained in:
Brian 2007-10-23 15:08:54 -06:00
parent 3df65af849
commit 4664261f8d
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/mesa/pipe/draw/draw_vertex_cache.c
View file

@ -59,6 +59,8 @@ static struct vertex_header *get_vertex( struct draw_context *draw,
{
unsigned slot = (i + (i>>5)) % VCACHE_SIZE;
assert(slot < 32); /* so we don't exceed the bitfield size below */
/* Cache miss?
*/
if (draw->vcache.idx[slot] != i) {
@ -80,6 +82,7 @@ static struct vertex_header *get_vertex( struct draw_context *draw,
/* Add to vertex shader queue:
*/
assert(draw->vs.queue_nr < VS_QUEUE_LENGTH);
draw->vs.queue[draw->vs.queue_nr].dest = draw->vcache.vertex[slot];
draw->vs.queue[draw->vs.queue_nr].elt = i;
draw->vs.queue_nr++;
@ -94,8 +97,14 @@ static struct vertex_header *get_vertex( struct draw_context *draw,
}
else {
// fprintf(stderr, "*");
/* primitive flushing may have cleared the bitfield but did not
* clear the idx[] array values. Set the bit now. This fixes a
* bug found when drawing long triangle fans.
*/
draw->vcache.referenced |= (1 << slot);
}
return draw->vcache.vertex[slot];
}