diff --git a/.pick_status.json b/.pick_status.json index 719d8fc0bc1..2a891121c1e 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -724,7 +724,7 @@ "description": "anv: fix 3d state initialization", "nominated": true, "nomination_type": 0, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": null }, diff --git a/src/intel/vulkan/genX_state.c b/src/intel/vulkan/genX_state.c index 263f09d6d64..ae4afc1f31a 100644 --- a/src/intel/vulkan/genX_state.c +++ b/src/intel/vulkan/genX_state.c @@ -299,7 +299,24 @@ init_render_queue_state(struct anv_queue *queue) anv_batch_emit(&batch, GENX(3DSTATE_WM_CHROMAKEY), ck); - genX(emit_sample_pattern)(&batch, NULL); + /* SKL PRMs, Volume 2a: Command Reference: Instructions: 3DSTATE_WM_HZ_OP: + * + * "3DSTATE_RASTER if used must be programmed prior to using this + * packet." + * + * Emit this before 3DSTATE_WM_HZ_OP below. + */ + anv_batch_emit(&batch, GENX(3DSTATE_RASTER), rast); + + /* SKL PRMs, Volume 2a: Command Reference: Instructions: 3DSTATE_WM_HZ_OP: + * + * "3DSTATE_MULTISAMPLE packet must be used prior to this packet to + * change the Number of Multisamples. This packet must not be used to + * change Number of Multisamples in a rendering sequence." + * + * Emit this before 3DSTATE_WM_HZ_OP below. + */ + genX(emit_multisample)(&batch, 1); /* The BDW+ docs describe how to use the 3DSTATE_WM_HZ_OP instruction in the * section titled, "Optimized Depth Buffer Clear and/or Stencil Buffer @@ -311,6 +328,8 @@ init_render_queue_state(struct anv_queue *queue) */ anv_batch_emit(&batch, GENX(3DSTATE_WM_HZ_OP), hzp); + genX(emit_sample_pattern)(&batch, NULL); + #if GFX_VER == 11 /* The default behavior of bit 5 "Headerless Message for Pre-emptable * Contexts" in SAMPLER MODE register is set to 0, which means