fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-07 11:28:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

util/u_vbuf: correct map offset calculation for crazy offsets

Browse source 
When the min_index is very large (or very negative), the multipliation
can overflow 32 bits and result in an incorrect map pointer
modification.

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
This commit is contained in:
Ilia Mirkin 2014-01-22 21:30:07 -05:00 • committed by Maarten Lankhorst
parent 3de97ce920
commit 45b64e52f4
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/gallium/auxiliary/util/u_vbuf.c
View file

@ -370,7 +370,7 @@ u_vbuf_translate_buffers(struct u_vbuf *mgr, struct translate_key *key,
/* Subtract min_index so that indexing with the index buffer works. */ /* Subtract min_index so that indexing with the index buffer works. */
if (unroll_indices) { if (unroll_indices) {
map -= vb->stride * min_index; map -= (ptrdiff_t)vb->stride * min_index;
} }
tr->set_buffer(tr, i, map, vb->stride, ~0); tr->set_buffer(tr, i, map, vb->stride, ~0);