fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-07 07:08:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

pan/genxml: remove non-existent YUV Enable for AFRC

Browse source 
This is controlled by the writeback-mode when using AFRC, not by an YUV
Enable field. This Filed doesn't exist in these, and should according to
the spec be zero.

Fixes: 7a763bb0a3 ("pan/genxml: Rework the RT/ZS emission logic")
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com>
(cherry picked from commit 15e0ac0731)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/40752>
This commit is contained in:
Erik Faye-Lund 2026-03-18 13:57:18 +01:00 • committed by Eric Engestrom
parent 9e5e58aa38
commit 4539139804
4 changed files with 1 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -5894,7 +5894,7 @@
"description": "pan/genxml: remove non-existent YUV Enable for AFRC",
"nominated": true,
"nomination_type": 2,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "7a763bb0a3b1cb48dce03a62fff2fe9eac3f0eaf",
"notes": null

2
src/panfrost/genxml/v10.xml
View file

@ -1904,7 +1904,6 @@
<struct name="AFRC RGB Render Target" align="64">
<field name="Writeback Mode" size="4" start="0:0" type="Writeback Mode" default="AFRC RGB"/>
<field name="Internal Buffer Offset" size="12" start="0:4" type="uint" modifier="shr(4)"/>
<field name="YUV Enable" size="1" start="0:24" type="bool" default="true"/>
<field name="Dithered Clear" size="1" start="0:25" type="bool"/>
<field name="Internal Format" size="6" start="0:26" type="Color Buffer Internal Format"/>
<field name="Writeback Format" size="8" start="1:0" type="Color Format"/>
@ -1923,7 +1922,6 @@
<struct name="AFRC YUV Render Target" align="64">
<field name="Writeback Mode" size="4" start="0:0" type="Writeback Mode" default="AFRC YUV"/>
<field name="Internal Buffer Offset" size="12" start="0:4" type="uint" modifier="shr(4)"/>
<field name="YUV Enable" size="1" start="0:24" type="bool" default="true"/>
<field name="Dithered Clear" size="1" start="0:25" type="bool"/>
<field name="Internal Format" size="6" start="0:26" type="Color Buffer Internal Format"/>
<field name="Writeback Format" size="8" start="1:0" type="Color Format"/>

2
src/panfrost/genxml/v12.xml
View file

@ -2192,7 +2192,6 @@
<struct name="AFRC RGB Render Target" align="64">
<field name="Writeback Mode" size="4" start="0:0" type="Writeback Mode" default="AFRC RGB"/>
<field name="Internal Buffer Offset" size="12" start="0:4" type="uint" modifier="shr(4)"/>
<field name="YUV Enable" size="1" start="0:24" type="bool" default="true"/>
<field name="Dithered Clear" size="1" start="0:25" type="bool"/>
<field name="Internal Format" size="6" start="0:26" type="Color Buffer Internal Format"/>
<field name="Writeback Format" size="8" start="1:0" type="Color Format"/>
@ -2211,7 +2210,6 @@
<struct name="AFRC YUV Render Target" align="64">
<field name="Writeback Mode" size="4" start="0:0" type="Writeback Mode" default="AFRC YUV"/>
<field name="Internal Buffer Offset" size="12" start="0:4" type="uint" modifier="shr(4)"/>
<field name="YUV Enable" size="1" start="0:24" type="bool" default="true"/>
<field name="Dithered Clear" size="1" start="0:25" type="bool"/>
<field name="Internal Format" size="6" start="0:26" type="Color Buffer Internal Format"/>
<field name="Writeback Format" size="8" start="1:0" type="Color Format"/>

2
src/panfrost/genxml/v13.xml
View file

@ -2498,7 +2498,6 @@
<struct name="AFRC RGB Render Target" align="64">
<field name="Writeback Mode" size="4" start="0:0" type="Writeback Mode" default="AFRC RGB"/>
<field name="Internal Buffer Offset" size="12" start="0:4" type="uint" modifier="shr(4)"/>
<field name="YUV Enable" size="1" start="0:24" type="bool" default="true"/>
<field name="Dithered Clear" size="1" start="0:25" type="bool"/>
<field name="Internal Format" size="6" start="0:26" type="Color Buffer Internal Format"/>
<field name="Writeback Format" size="8" start="1:0" type="Color Format"/>
@ -2517,7 +2516,6 @@
<struct name="AFRC YUV Render Target" align="64">
<field name="Writeback Mode" size="4" start="0:0" type="Writeback Mode" default="AFRC YUV"/>
<field name="Internal Buffer Offset" size="12" start="0:4" type="uint" modifier="shr(4)"/>
<field name="YUV Enable" size="1" start="0:24" type="bool" default="true"/>
<field name="Dithered Clear" size="1" start="0:25" type="bool"/>
<field name="Internal Format" size="6" start="0:26" type="Color Buffer Internal Format"/>
<field name="Writeback Format" size="8" start="1:0" type="Color Format"/>