fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-03-10 22:20:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

anv: Drop the slow clear heuristic
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
Details
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Details

Browse source 
This no longer provides a performance improvement.

Reviewed-by: Rohan Garg <rohan.garg@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33776>
This commit is contained in:
Nanley Chery 2025-01-31 04:04:26 -05:00 • committed by Marge Bot
parent 67d60f4325
commit 4502254cd2
3 changed files with 0 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/intel/vulkan/anv_image.c
View file

@ -3548,21 +3548,6 @@ anv_can_fast_clear_color(const struct anv_cmd_buffer *cmd_buffer,
return false;
}
/* The fast-clear preamble and/or postamble flushes are more expensive than
* the flushes performed by BLORP during slow clears. Use a heuristic to
* determine if the cost of the flushes are worth fast-clearing. See
* genX(cmd_buffer_update_color_aux_op)() and blorp_exec_on_render().
* TODO: Tune for Xe2
*/
if (cmd_buffer->device->info->verx10 <= 125 &&
cmd_buffer->num_independent_clears >= 16 &&
cmd_buffer->num_independent_clears >
cmd_buffer->num_dependent_clears * 2) {
anv_perf_warn(VK_LOG_OBJS(&image->vk.base),
"Not enough back-to-back fast-clears. Slow clearing.");
return false;
}
return true;
}

4
src/intel/vulkan/anv_private.h
View file

@ -4352,10 +4352,6 @@ struct anv_cmd_buffer {
struct anv_cmd_state state;
/* Fast-clear statistics. */
uint64_t num_dependent_clears;
uint64_t num_independent_clears;
struct anv_address return_addr;
/* Set by SetPerformanceMarkerINTEL, written into queries by CmdBeginQuery */

8
src/intel/vulkan/genX_cmd_buffer.c
View file

@ -3144,14 +3144,6 @@ genX(cmd_buffer_update_color_aux_op)(struct anv_cmd_buffer *cmd_buffer,
} else {
cmd_buffer->state.color_aux_op = next_aux_op;
}
if (next_aux_op == ISL_AUX_OP_FAST_CLEAR) {
if (aux_op_clears(last_aux_op)) {
cmd_buffer->num_dependent_clears++;
} else {
cmd_buffer->num_independent_clears++;
}
}
}
static void