fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-24 01:58:16 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

tu: Zero out unused parts of descriptors

Browse source 
UBO and sampler descriptors are smaller than texture descriptors, but
the nature of Vulkan descriptor sets means we need to make them just as
big. Zero out the remaining dwords so that we don't get garbage that
trips up asserts in gfxrecon-replay.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41608>
This commit is contained in:
Connor Abbott 2026-05-15 16:34:31 -04:00 • committed by Marge Bot
parent ad14a81cc7
commit 4441ad835c
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/freedreno/vulkan/tu_descriptor_set.cc
View file

@ -1088,6 +1088,9 @@ write_ubo_descriptor_addr(uint32_t *dst,
uint32_t range = va ? DIV_ROUND_UP(buffer_info->range, 16) : 0;
dst[0] = A6XX_UBO_0_BASE_LO(va);
dst[1] = A6XX_UBO_1_BASE_HI(va >> 32) | A6XX_UBO_1_SIZE(range);
for (unsigned i = 2; i < FDL6_TEX_CONST_DWORDS; i++)
dst[i] = 0;
}
static void
@ -1129,6 +1132,8 @@ write_combined_image_sampler_descriptor(uint32_t *dst,
if (write_sampler) {
VK_FROM_HANDLE(tu_sampler, sampler, image_info->sampler);
memcpy(dst + FDL6_TEX_CONST_DWORDS, sampler->descriptor, sizeof(sampler->descriptor));
for (unsigned i = A6XX_TEX_SAMP_DWORDS; i < FDL6_TEX_CONST_DWORDS; i++)
dst[i + FDL6_TEX_CONST_DWORDS] = 0;
}
/* It's technically legal to sample from a mismatched descriptor (i.e. only
@ -1157,6 +1162,8 @@ write_sampler_descriptor(uint32_t *dst, VkSampler _sampler)
VK_FROM_HANDLE(tu_sampler, sampler, _sampler);
memcpy(dst, sampler->descriptor, sizeof(sampler->descriptor));
for (unsigned i = A6XX_TEX_SAMP_DWORDS; i < FDL6_TEX_CONST_DWORDS; i++)
dst[i] = 0;
}
template <chip CHIP>